[00:13] snover (~Adium@unaffiliated/snover) left irc: Quit: Leaving. [00:14] waltervn (~waltervn@82-171-142-149.ip.telfort.nl) left irc: Quit: Leaving [00:52] TMM (~hp@fsf/member/pdpc.professional.tmm) joined #scummvm. [01:00] dreammaster (~dreammast@c-73-167-118-204.hsd1.ma.comcast.net) joined #scummvm. [01:00] #scummvm: mode change '+o dreammaster' by ChanServ!ChanServ@services. [01:10] SylvainTV (~SylvainTV@LFbn-1-6090-118.w90-110.abo.wanadoo.fr) left irc: Read error: Connection reset by peer [01:14] GitHub73 (~GitHub73@192.30.252.40) joined #scummvm. [01:14] [scummvm] tsoliman pushed 1 new commit to branch-1-8-1: https://git.io/vrgEm [01:14] scummvm/branch-1-8-1 4aa4747 Tarek Soliman: MAEMO: Update debian/changelog [01:14] GitHub73 (GitHub73@192.30.252.40) left #scummvm. [01:15] GitHub106 (~GitHub106@192.30.252.40) joined #scummvm. [01:15] [scummvm] tsoliman pushed 1 new commit to branch-1-8: https://git.io/vrgEs [01:15] scummvm/branch-1-8 bec9e4f Tarek Soliman: MAEMO: Update debian/changelog [01:15] GitHub106 (GitHub106@192.30.252.40) left #scummvm. [01:17] GitHub150 (~GitHub150@192.30.252.34) joined #scummvm. [01:17] [scummvm] tsoliman pushed 1 new commit to master: https://git.io/vrgEl [01:17] scummvm/master e689b70 Tarek Soliman: MAEMO: Update debian/changelog... [01:17] GitHub150 (GitHub150@192.30.252.34) left #scummvm. [01:20] Dominus (~dominus@unaffiliated/dominus) left irc: Ping timeout: 246 seconds [01:22] Dominus (~dominus@unaffiliated/dominus) joined #scummvm. [02:14] snover (~Adium@unaffiliated/snover) joined #scummvm. [02:14] #scummvm: mode change '+o snover' by ChanServ!ChanServ@services. [02:15] Tomaz^ (~tompsson@h-236-221.a199.priv.bahnhof.se) joined #scummvm. [02:20] _dreammaster (~dreammast@c-73-167-118-204.hsd1.ma.comcast.net) joined #scummvm. [02:20] #scummvm: mode change '+o _dreammaster' by ChanServ!ChanServ@services. [02:22] dreammaster (~dreammast@c-73-167-118-204.hsd1.ma.comcast.net) left irc: Ping timeout: 250 seconds [02:35] LordHoto (~loom@unaffiliated/lordhoto) left irc: Quit: ... [02:40] _dreammaster (~dreammast@c-73-167-118-204.hsd1.ma.comcast.net) left irc: [02:50] snover (~Adium@unaffiliated/snover) left irc: Quit: Leaving. [03:15] fyi, mac os 10.5 support is being removed for SDL 2.0.5 [04:02] Poly-C (~Poly-C@gentoo/developer/Polynomial-C) joined #scummvm. [04:04] Polynomial-C (~Poly-C@gentoo/developer/Polynomial-C) left irc: Ping timeout: 244 seconds [04:13] Littleboy (~littleboy@c-24-91-129-251.hsd1.ma.comcast.net) left irc: Ping timeout: 276 seconds [04:57] Littleboy (~littleboy@c-24-147-104-194.hsd1.ma.comcast.net) joined #scummvm. [04:57] #scummvm: mode change '+o Littleboy' by ChanServ!ChanServ@services. [05:08] good morning [05:40] Mia (~Mia@unaffiliated/mia) joined #scummvm. [05:42] has somebody here experience with compiling scummvm under msys2? [05:43] compilation runs fine using the mingw64 environment and the libraries provided by msys2 [05:43] scummvm also starts when I run it from within msys2 [05:43] but if I try to execute the file outside of msys2, it complains about missing lib dlls [05:43] so I need to get the thing statically linked... but passing LDFLAGS=-static only throws out errors while linking [05:49] but I have the feeling that all libraries in the msys2 repository are dynamically linked... so maybe I have to compile all necessary libraries from scratch and link them statically [06:07] Littleboy (~littleboy@c-24-147-104-194.hsd1.ma.comcast.net) left irc: Quit: Ętre dans le vent, une ambition de feuille morte. [06:12] GitHub186 (~GitHub186@192.30.252.41) joined #scummvm. [06:12] [scummvm] rootfather pushed 1 new commit to master: https://git.io/vrgri [06:12] scummvm/master 10cbeb1 Lothar Serra Mari: NEWS/DE: Mention androidsl port [06:12] GitHub186 (GitHub186@192.30.252.41) left #scummvm. [06:29] ny00123 (~ny00123@46-116-85-1.bb.netvision.net.il) joined #scummvm. [06:35] ruskie (ruskie@sourcemage/mage/ruskie) left irc: Excess Flood [06:35] ruskie (ruskie@sourcemage/mage/ruskie) joined #scummvm. [06:52] Mia (~Mia@unaffiliated/mia) left irc: Read error: Connection reset by peer [07:00] uruk-hai (~uruk-hai@catv-80-99-64-76.catv.broadband.hu) joined #scummvm. [07:00] #scummvm: mode change '+o uruk-hai' by ChanServ!ChanServ@services. [07:29] m_kiewitz (~m_kiewitz@x4d03f747.dyn.telefonica.de) joined #scummvm. [07:29] m_kiewitz (~m_kiewitz@x4d03f747.dyn.telefonica.de) left irc: Changing host [07:29] m_kiewitz (~m_kiewitz@scummvm/undead/m-kiewitz) joined #scummvm. [07:29] #scummvm: mode change '+o m_kiewitz' by ChanServ!ChanServ@services. [07:52] salty-horse (~salty-hor@unaffiliated/salty-horse) joined #scummvm. [07:52] #scummvm: mode change '+o salty-horse' by ChanServ!ChanServ@services. [07:56] mkiewitz (~m_kiewitz@x4d03f747.dyn.telefonica.de) joined #scummvm. [07:56] m_kiewitz (~m_kiewitz@scummvm/undead/m-kiewitz) left irc: Read error: Connection reset by peer [07:56] mkiewitz (~m_kiewitz@x4d03f747.dyn.telefonica.de) left irc: Client Quit [07:56] m_kiewitz (~m_kiewitz@scummvm/undead/m-kiewitz) joined #scummvm. [07:56] #scummvm: mode change '+o m_kiewitz' by ChanServ!ChanServ@services. [08:09] m_kiewitz (~m_kiewitz@scummvm/undead/m-kiewitz) left irc: Read error: Connection reset by peer [08:13] uruk-hai (~uruk-hai@catv-80-99-64-76.catv.broadband.hu) left irc: Ping timeout: 276 seconds [08:23] m_kiewitz (~m_kiewitz@scummvm/undead/m-kiewitz) joined #scummvm. [08:23] #scummvm: mode change '+o m_kiewitz' by ChanServ!ChanServ@services. [08:48] Henke37 (~Henrik@81-227-16-59-no133.bredband.skanova.com) joined #scummvm. [08:51] uruk-hai (~uruk-hai@catv-80-99-64-76.catv.broadband.hu) joined #scummvm. [08:51] #scummvm: mode change '+o uruk-hai' by ChanServ!ChanServ@services. [09:03] WooShell (~Markus@ipbcc34ce4.dynamic.kabel-deutschland.de) joined #scummvm. [09:03] good meowning =^.^= [09:07] Harekiet (~harekiet@kittens.harekiet.com) left irc: Read error: Connection reset by peer [09:10] Harekiet (~harekiet@kittens.harekiet.com) joined #scummvm. [09:13] waltervn (~waltervn@82-171-142-149.ip.telfort.nl) joined #scummvm. [09:13] #scummvm: mode change '+o waltervn' by ChanServ!ChanServ@services. [09:19] Begasus (~Begas_@d54c3d303.access.telenet.be) joined #scummvm. [09:54] salty-bot (~salty-bot@192.30.252.40) joined #scummvm. [09:54] [kom] salty-horse pushed 1 new commit to master: https://git.io/vrg1Z [09:54] kom/master cfa234d Ori Avtalion: Change header guard style to match ScummVM [09:54] salty-bot (salty-bot@192.30.252.40) left #scummvm. [10:04] ajax16384 (~User@ip33.net130.n37.ru) joined #scummvm. [10:04] #scummvm: mode change '+o ajax16384' by ChanServ!ChanServ@services. [10:37] Do we currently accept bug reports for the iOS-port? [10:41] uruk (~Peter@catv-80-99-64-76.catv.broadband.hu) joined #scummvm. [10:42] uruk (~Peter@catv-80-99-64-76.catv.broadband.hu) left irc: Client Quit [10:42] uruk-hai (~uruk-hai@catv-80-99-64-76.catv.broadband.hu) left irc: Quit: Leaving [10:42] uruk-hai (~Peter@catv-80-99-64-76.catv.broadband.hu) joined #scummvm. [10:42] #scummvm: mode change '+o uruk-hai' by ChanServ!ChanServ@services. [10:43] uruk-hai (~Peter@catv-80-99-64-76.catv.broadband.hu) left irc: Client Quit [10:43] GitHub115 (~GitHub115@192.30.252.40) joined #scummvm. [10:43] [scummvm] salty-horse opened pull request #759: NEVERHOOD: Reduce audio header dependencies (master...neverhood_audio) https://git.io/vrgDf [10:43] GitHub115 (GitHub115@192.30.252.40) left #scummvm. [10:43] uruk-hai (~Peter@catv-80-99-64-76.catv.broadband.hu) joined #scummvm. [10:43] #scummvm: mode change '+o uruk-hai' by ChanServ!ChanServ@services. [10:59] frankyboy_ (~franky@ppp91-78-195-201.pppoe.mtu-net.ru) joined #scummvm. [11:06] uruk_hai (~Peter@catv-80-99-64-76.catv.broadband.hu) joined #scummvm. [11:06] #scummvm: mode change '+o uruk_hai' by ChanServ!ChanServ@services. [11:10] uruk-hai (~Peter@catv-80-99-64-76.catv.broadband.hu) left irc: Ping timeout: 252 seconds [11:12] SylvainTV (~SylvainTV@LFbn-1-6090-118.w90-110.abo.wanadoo.fr) joined #scummvm. [11:12] #scummvm: mode change '+o SylvainTV' by ChanServ!ChanServ@services. [11:32] GitHub75 (~GitHub75@192.30.252.34) joined #scummvm. [11:32] [scummvm] salty-horse opened pull request #760: SCUMM: Reduce audio header dependencies (master...scumm_audio) https://git.io/vrgyp [11:32] GitHub75 (GitHub75@192.30.252.34) left #scummvm. [11:37] somaen: this is an official port, so I suppose we do (I don't see any reason why will would refuse bug reports) [11:38] frankyboy_ (~franky@ppp91-78-195-201.pppoe.mtu-net.ru) left irc: Remote host closed the connection [11:51] DJWillis (~djwillis@cpc2-trow6-2-0-cust204.aztw.cable.virginm.net) left irc: Read error: Connection reset by peer [11:51] DJWillis (~djwillis@cpc2-trow6-2-0-cust204.aztw.cable.virginm.net) joined #scummvm. [11:51] #scummvm: mode change '+o DJWillis' by ChanServ!ChanServ@services. [11:58] ajax16384 (~User@ip33.net130.n37.ru) left irc: Read error: Connection reset by peer [12:10] Cheeseness (~cheesenes@ppp14-2-131-90.lns20.hba1.internode.on.net) left irc: Quit: Leaving. [12:19] uruk_hai (~Peter@catv-80-99-64-76.catv.broadband.hu) left irc: Read error: Connection reset by peer [12:23] uruk-hai (~Peter@catv-80-99-64-76.catv.broadband.hu) joined #scummvm. [12:23] #scummvm: mode change '+o uruk-hai' by ChanServ!ChanServ@services. [12:27] Cheeseness (~cheesenes@ppp14-2-131-90.lns20.hba1.internode.on.net) joined #scummvm. [12:29] LordHoto (~loom@unaffiliated/lordhoto) joined #scummvm. [12:29] #scummvm: mode change '+o LordHoto' by ChanServ!ChanServ@services. [12:32] Strangerke (~Strangerk@cable-85.28.84.13.coditel.net) left irc: Ping timeout: 260 seconds [12:34] Begasus (~Begas_@d54c3d303.access.telenet.be) left irc: Read error: Connection reset by peer [12:35] Strangerke (~Strangerk@cable-85.28.84.13.coditel.net) joined #scummvm. [12:36] Begasus (~Begas_@d54C3D303.access.telenet.be) joined #scummvm. [12:40] Begasus (~Begas_@d54C3D303.access.telenet.be) left irc: Client Quit [12:49] sherlock devs, is it correct that this speech playback call reports itself to the mixer as a "Sound" instead of a "Speech"? https://github.com/scummvm/scummvm/blob/master/engines/sherlock/sound.cpp#L258 [12:49] m_kiewitz, ? [12:49] that specific one should probably be answered by dreammaster [13:27] blorente (~blorente@84.red-193-153-188.dynamicip.rima-tde.net) joined #scummvm. [13:27] #scummvm: mode change '+v blorente' by ChanServ!ChanServ@services. [13:27] Afternoon, everybody :9 [13:37] snover (~Adium@unaffiliated/snover) joined #scummvm. [13:37] #scummvm: mode change '+o snover' by ChanServ!ChanServ@services. [14:05] WooShell (~Markus@ipbcc34ce4.dynamic.kabel-deutschland.de) left irc: Ping timeout: 260 seconds [14:08] WooShell (~Markus@ipbcc34ce4.dynamic.kabel-deutschland.de) joined #scummvm. [14:21] heroux (sandroco@gateway/shell/insomnia247/x-bfoptdavxcqwdjfe) left irc: Ping timeout: 240 seconds [14:22] heroux (sandroco@gateway/shell/insomnia247/x-hhdvqhgsbaqabycm) joined #scummvm. [14:44] Deledrius_ (~Deledrius@2602:100:42d7:b57d:7857:22f8:755d:67ce) joined #scummvm. [14:47] Deledrius (~Deledrius@2602:100:42d7:b57d:7857:22f8:755d:67ce) left irc: Ping timeout: 260 seconds [15:02] blorente1 (~blorente@84.red-193-153-188.dynamicip.rima-tde.net) joined #scummvm. [15:04] blorente (~blorente@84.red-193-153-188.dynamicip.rima-tde.net) left irc: Ping timeout: 252 seconds [15:12] Begasus (~Begas_@d54C3D303.access.telenet.be) joined #scummvm. [15:14] #scummvm: mode change '+v blorente1' by ChanServ!ChanServ@services. [15:14] Nick change: blorente1 -> blorente [15:17] ajax16384 (~User@ip33.net130.n37.ru) joined #scummvm. [15:17] #scummvm: mode change '+o ajax16384' by ChanServ!ChanServ@services. [15:55] Littleboy (~littleboy@c-24-147-104-194.hsd1.ma.comcast.net) joined #scummvm. [15:55] #scummvm: mode change '+o Littleboy' by ChanServ!ChanServ@services. [16:04] uruk-hai (~Peter@catv-80-99-64-76.catv.broadband.hu) left irc: Quit: Leaving [16:23] Henke37 (~Henrik@81-227-16-59-no133.bredband.skanova.com) left irc: Read error: Connection reset by peer [16:38] blorente (~blorente@84.red-193-153-188.dynamicip.rima-tde.net) left irc: Ping timeout: 244 seconds [16:40] Begasus (~Begas_@d54C3D303.access.telenet.be) left irc: Read error: No route to host [16:40] Begas_ (~Begas_@d54C3D303.access.telenet.be) joined #scummvm. [16:45] Henke37 (~Henrik@81-227-16-59-no133.bredband.skanova.com) joined #scummvm. [16:47] Nick change: Begas_ -> Begasus [17:17] Mia (~Mia@176.234.0.220) joined #scummvm. [17:17] Mia (~Mia@176.234.0.220) left irc: Changing host [17:17] Mia (~Mia@unaffiliated/mia) joined #scummvm. [17:17] Mia (~Mia@unaffiliated/mia) left irc: Read error: Connection reset by peer [17:18] Mia (~Mia@176.234.0.220) joined #scummvm. [17:18] Mia (~Mia@176.234.0.220) left irc: Changing host [17:18] Mia (~Mia@unaffiliated/mia) joined #scummvm. [17:24] {V} (~V@105-70-ftth.on.nl) left irc: Ping timeout: 252 seconds [17:29] {V} (~V@105-70-ftth.on.nl) joined #scummvm. [17:46] scummvm still on par on Haiku :) [17:48] frankyboy_ (~franky@ppp91-78-195-201.pppoe.mtu-net.ru) joined #scummvm. [17:52] _sev: would it be possible to have a coverity report including Gnap? I'm fed up to wait for the merge and I'd like some action :) [18:16] dreammaster (~dreammast@c-73-167-118-204.hsd1.ma.comcast.net) joined #scummvm. [18:16] #scummvm: mode change '+o dreammaster' by ChanServ!ChanServ@services. [18:17] salty-horse: Regarding sherlock voices, from memory I originally toyed with using the speech sound type, but I later discovered that what the original called "speech" also included digital sound effects too [18:18] And since everything is controlled by scripts, I wasn't able to figure out any clean way to tell the difference. And I couldn't just check based on filename, since different regionalizations could have different filenames [18:19] Speaking of Sherlock sound, there's still my attempt at making a MusicPlayer class for Sherlock that could use someone's assistence in getting working, so that music obeys the music volume slider [18:19] dreammaster, ok. makes sense [18:19] I don't have the game [18:20] I've said it before, and I'll say it again.. sound is my least favorite part of game development :) [18:29] yupp [18:43] <_sev> Strangerke: no, I do not see an easy way until it is erged [18:44] Note to myself: next time make the PR a friday, so it's merged for a weekend [18:53] GitHub70 (~GitHub70@192.30.252.46) joined #scummvm. [18:53] [scummvm-sites] sev- pushed 1 new commit to web-planet: https://github.com/scummvm/scummvm-sites/commit/ab3afb0627426f77009b3b27db481be5df80f471 [18:53] scummvm-sites/web-planet ab3afb0 Eugene Sandulenko: PLANET: Cleanup blogs of retired and inactive team members [18:53] GitHub70 (GitHub70@192.30.252.46) left #scummvm. [19:17] Mia (~Mia@unaffiliated/mia) left irc: Read error: Connection reset by peer [19:17] Mia (~Mia@unaffiliated/mia) joined #scummvm. [20:09] m_kiewitz: there? [20:09] yes [20:10] I'm trying to figure why my patch won't work correctly when loading a savegame in room 285 [20:10] what's your signature for the locals patch? [20:10] the patcher logs that it patched [20:10] everything? [20:10] if i exit the room and return - it works correctly [20:11] but until i do that - the new message is not available [20:11] i guess it sets up the pointer to the local right when entering [20:12] my signature works when loading the save game - because it says so: [20:12] Script-Patcher: 'missing points for telling about initiation' on script 285 offset 2216 [20:12] Script-Patcher: 'missing points for telling about initiation' on script 285 offset 284 [20:12] Script-Patcher: 'missing points for telling about initiation' on script 285 offset 405 [20:13] yes, but the problem is in case the scripts set up the pointer to the local when entering the room [20:13] then that pointer is set inside the saved game [20:13] can you check the egoTell object? [20:14] egoTell.curArray = 0028:0138 [20:14] when I look in that address it doesn't look patched [20:14] the array is 14 words long instead of 15 [20:14] Tkachov (Tkachov@gateway/shell/fnordserver.eu/x-wvwrostfubopylmv) left irc: Remote host closed the connection [20:15] ah right [20:15] so I guess the patcher patched some other place in memory? [20:15] the locals are in memory [20:15] and they will be loaded from the heap resource only when they are initialized [20:15] so nothing we can do about that [20:15] ok [20:15] at least it's not a bug in my patch [20:15] can you check if rm285::init is called when loading the saved game? [20:15] i'll carry on then - thanks! [20:16] yes, i can check that [20:16] if it is, then in theory we could change the locals in there instead of patching the heap [20:16] it doesn't [20:16] damn [20:17] well i guess we could also keep it like it is [20:17] only when i re-enter the room [20:17] yeah, it's not terrible [20:17] what else is it calling when processing the dialog choice? [20:18] egoTell::doChild? [20:18] rm285::doVerb? [20:19] anyway i guess we could really keep it like this. it's a bug in the original game, so it's not like we fix a bug that only happens in ScummVM [20:20] egoTell::response ==> egoTell:showDialog ==> Teller:showDialog ==> egoTell::doDialog [20:21] hmm egoTell::showDialog could maybe get optimized, so that we could patch the locals from there [20:21] on the other hand i don't know if that's worth it [20:21] egoTell::doVerb ==> Teller:doVerb ==> (the previous line I wrote) [20:22] hmm at least it won't crash or do anything badly currently, so i guess we could just keep it [20:22] it works for GOG version too? [20:22] egoTell::showDialog is building the array of (message,bool) tuples that should be shown [20:22] Yes, I verified with GOG + QFG Collection in all languages [20:24] just add a comment saying that you have to re-enter the room in case a saved game was loaded from a previous version of ScummVM and that saved game was made inside that room [20:24] sure [20:24] most people won't notice anyway [20:25] ajax16384 (~User@ip33.net130.n37.ru) left irc: Read error: Connection reset by peer [20:26] just a short notice before going to bed - I really like the idea of a compatibility database like dosbox has [20:26] but I have no idea how to encourage users for testing [20:30] I hope this is not an indicator for a declining user base :P [20:31] I must admit that for once I don't like the idea [20:31] I always considered it was bullshit in dosbox [20:31] but if it helps... [20:31] good night folks [20:32] Strangerke, maybe we find a better idea :P [20:32] maybe the lack of testing is a sign of "it just works" :D [20:33] if enough people thinks it's a good idea, why not [20:33] maybe we should start handing out special badges in the forum profiles for testers [20:33] or mention the testers in the AUTHORS file or somewhere else in the credits [20:33] yes, gamification could help [20:33] anyway, see you tomorrow [20:34] crazy idea, maybe something like the Windows Insider app... [20:34] basically we write a bunch of tasks [20:34] salty-horse (~salty-hor@unaffiliated/salty-horse) left irc: Quit: Leaving [20:35] and solving those tasks would force people to play the game [20:35] <_sev> and what is the reward? [20:35] Achievements :D [20:36] honestly, I don't know [20:36] <_sev> yeah, and display them on the main website [20:36] good night ppl [20:36] have to get up at 4:00 UTC again :/ [20:36] damn, 3:00 UTC even [20:37] ... you would spare a lot of energy if you didn't go to sleep at all :) [20:48] Littleboy (~littleboy@c-24-147-104-194.hsd1.ma.comcast.net) left irc: Read error: Connection reset by peer [20:49] Littleboy (~littleboy@c-24-147-104-194.hsd1.ma.comcast.net) joined #scummvm. [20:49] #scummvm: mode change '+o Littleboy' by ChanServ!ChanServ@services. [20:51] Begasus (~Begas_@d54C3D303.access.telenet.be) left irc: Quit: Vision[0.9.7-H-20140108]: i've been blurred! [20:59] ny00123 (~ny00123@46-116-85-1.bb.netvision.net.il) left irc: Quit: Leaving [21:16] frankyboy_ (~franky@ppp91-78-195-201.pppoe.mtu-net.ru) left irc: Read error: Connection reset by peer [21:17] frankyboy_ (~franky@ppp91-78-195-201.pppoe.mtu-net.ru) joined #scummvm. [21:30] GitHub54 (~GitHub54@192.30.252.45) joined #scummvm. [21:30] [scummvm] OmerMor opened pull request #761: SCI: Script patch for fixing 3 missing points in QfG3 (master...qfg3_missing_points) https://git.io/vr2Oo [21:30] GitHub54 (GitHub54@192.30.252.45) left #scummvm. [21:30] m_kiewitz: still there? [21:31] yes [21:31] just created a PR [21:31] when you have some time - please review it [21:32] (and please don't forget about the previous PR: https://github.com/scummvm/scummvm/pull/750) [21:33] you can remove the "SIG_ADDTOOFFSET(+2)" at the end of the first signature [21:33] although maybe better keep it [21:33] I got an error without it: [21:33] my patch was writing beyond the signature end [21:34] ah [21:34] so i made sure [21:34] ok [21:34] i didn't remember that i added a check for that [21:35] the script opcodes should all align [21:35] i mean the script opcodes in the comments [21:36] besides that it looks fine [21:38] yeah, there's an alignment mismatch between my editor and github [21:38] the style guide says use tabs for indentation, but in practice the file I'm editing is all about spaces [21:39] I'll change my tabs to spaces [21:40] we use spaces normally for comments that are added to regular code [21:40] regular code lines [21:40] In Google we only use spaces [21:41] omer_mor: I think our style guid talks about indentation when it comes to nesting levels etc., the comments are more of a "make it look nice" and that's done with spaces [21:41] *guide [21:42] omer_mor: it's not really an indentation issue there [21:43] sure, no problem [21:43] omer_mor: similar to when you have multiple lines of function parameters, you don't use tabs for that, except for the parts for the nesting level [21:43] LordHoto: maybe you want to make that explicit in the style guide [21:44] omer_mor: maybe [21:45] m_kiewitz: done [21:46] frankyboy_ (~franky@ppp91-78-195-201.pppoe.mtu-net.ru) left irc: Read error: Connection reset by peer [21:46] omer_mor: but I think it's reasonably clear that indentation should be done with tabs, but it might not be clear that other stuff shouldn't be done with tabs [21:47] frankyboy_ (~franky@ppp91-78-195-201.pppoe.mtu-net.ru) joined #scummvm. [21:47] LordHoto: yes, of course. [21:48] Tkachov (Tkachov@gateway/shell/fnordserver.eu/x-jsdsoyadxnzihhkw) joined #scummvm. [21:49] I read the guideline of "Tab indents, with tabstop at four spaces" as "Tab should be used EVERYWHERE!!1!1" [21:49] I think we should simply cut the "at four spaces" thing, which is pretty annoying in the times of web views on source code which usually use things like 8 spaces [21:50] its weird to combine tab indents with a guidance for a specific size of tabs since the primary benefit of tabs is that people can choose their preferred indentation :) [21:50] and maybe add some clarification that everything else should be spaces [21:50] (which obviously the correct answer, by on committee rule, is 3) [21:50] snover: yeah, I guess that's where this confusion comes from [21:56] Nick change: Deledrius_ -> Deledrius [22:30] WooShell (~Markus@ipbcc34ce4.dynamic.kabel-deutschland.de) left irc: Quit: Zu gotdy od mpy nrmy stpimf. Zu drvpmf zrsmd aogy jrt iq pt viy jrt yp yjr htpimf. [22:38] Henke37 (~Henrik@81-227-16-59-no133.bredband.skanova.com) left irc: Quit: ERR_SHUTDOWN [22:43] GitHub101 (~GitHub101@192.30.252.45) joined #scummvm. [22:43] [scummvm] m-kiewitz closed pull request #761: SCI: Script patch for fixing 3 missing points in QfG3 (master...qfg3_missing_points) https://git.io/vr2Oo [22:43] GitHub101 (GitHub101@192.30.252.45) left #scummvm. [22:43] GitHub134 (~GitHub134@192.30.252.34) joined #scummvm. [22:43] [scummvm] m-kiewitz pushed 2 new commits to master: https://git.io/vr2GS [22:43] scummvm/master aaf8cbc Omer Mor: SCI: Script patch for fixing 3 missing points in QfG3... [22:43] scummvm/master e62895a Martin Kiewitz: Merge pull request #761 from OmerMor/qfg3_missing_points... [22:43] GitHub134 (GitHub134@192.30.252.34) left #scummvm. [22:45] GitHub147 (~GitHub147@192.30.252.46) joined #scummvm. [22:45] [scummvm] sev- pushed 11 new commits to master: https://git.io/vr2G5 [22:45] scummvm/master 4ed193b Eugene Sandulenko: SCUMM HE: Documented more opcodes [22:45] scummvm/master 9d60209 Eugene Sandulenko: SCUMM HE: Initial stub for Moonbase AI [22:45] scummvm/master adc884a Eugene Sandulenko: SCUMM HE: AIEntity class implementation [22:45] GitHub147 (GitHub147@192.30.252.46) left #scummvm. [22:45] <_sev> let's see how happy buildbot will be [23:10] frankyboy_ (~franky@ppp91-78-195-201.pppoe.mtu-net.ru) left irc: Remote host closed the connection [23:19] GitHub112 (~GitHub112@192.30.252.34) joined #scummvm. [23:19] [scummvm] sev- closed pull request #760: SCUMM: Reduce audio header dependencies (master...scumm_audio) https://git.io/vrgyp [23:19] GitHub112 (GitHub112@192.30.252.34) left #scummvm. [23:19] GitHub149 (~GitHub149@192.30.252.45) joined #scummvm. [23:19] [scummvm] sev- pushed 2 new commits to master: https://git.io/vr2ZF [23:19] scummvm/master 3ad6af9 Ori Avtalion: SCUMM: Reduce audio header dependencies [23:19] scummvm/master 377a611 Eugene Sandulenko: Merge pull request #760 from salty-horse/scumm_audio... [23:19] GitHub149 (GitHub149@192.30.252.45) left #scummvm. [23:19] GitHub106 (~GitHub106@192.30.252.46) joined #scummvm. [23:19] [scummvm] sev- closed pull request #759: NEVERHOOD: Reduce audio header dependencies (master...neverhood_audio) https://git.io/vrgDf [23:19] GitHub106 (GitHub106@192.30.252.46) left #scummvm. [23:19] GitHub127 (~GitHub127@192.30.252.45) joined #scummvm. [23:19] [scummvm] sev- pushed 2 new commits to master: https://git.io/vr2Zx [23:19] scummvm/master 2175309 Ori Avtalion: NEVERHOOD: Reduce audio header dependencies [23:19] scummvm/master 6581bca Eugene Sandulenko: Merge pull request #759 from salty-horse/neverhood_audio... [23:19] GitHub127 (GitHub127@192.30.252.45) left #scummvm. [23:26] waltervn (~waltervn@82-171-142-149.ip.telfort.nl) left irc: Quit: Leaving [23:52] Schnabeltierchen (~Schnabelt@xdsl-89-0-123-61.netcologne.de) left irc: Ping timeout: 240 seconds [23:55] Littleboy (~littleboy@c-24-147-104-194.hsd1.ma.comcast.net) left irc: Disconnected by services [23:55] Littleboy_ (~littleboy@c-24-147-104-194.hsd1.ma.comcast.net) joined #scummvm. [23:55] #scummvm: mode change '+o Littleboy_' by ChanServ!ChanServ@services. [23:55] Schnabeltierchen (~Schnabelt@xdsl-87-79-233-161.netcologne.de) joined #scummvm. [23:56] m_kiewitz (~m_kiewitz@scummvm/undead/m-kiewitz) left irc: Quit: technology isn't intrinsically good or evil. It's how it's used. Like the Death Ray. [00:00] --- Sun May 22 2016