ScummVM IRC Log - 20 Sep 2017

[Back to Index]

[00:00] --> GitHub111 joined #scummvm.
[00:00] <GitHub111> [scummvm] dreammaster pushed 1 new commit to master: https://git.io/v5pvJ
[00:00] <GitHub111> scummvm/master 0a44b54 Paul Gilbert: TITANIC: Fix memory leaks on shutdown
[00:00] GitHub111 (GitHub111@192.30.252.34) left #scummvm.
[00:02] <-- Littleboy left irc: Read error: Connection reset by peer
[00:03] --> Littleboy joined #scummvm.
[00:03] #scummvm: mode change '+o Littleboy' by ChanServ!ChanServ@services.
[00:14] <snover> https://blog.fuzzing-project.org/60-Optionsbleed-HTTP-OPTIONS-method-can-leak-Apaches-server-memory.html :(
[01:02] <snover> hold onto your butts.
[01:02] --> GitHub121 joined #scummvm.
[01:02] <GitHub121> [scummvm] csnover pushed 14 new commits to master: https://git.io/v5pT2
[01:02] <GitHub121> scummvm/master 2f99675 Colin Snover: SCI: Stop EngineState::wait mutating r_acc...
[01:02] <GitHub121> scummvm/master b0b1e89 Colin Snover: SCI32: Hide warning about CD-ROM speed setting in kGetSierraProfileInt...
[01:02] <GitHub121> scummvm/master d9ad1a3 Colin Snover: SCI32: Promote Lighthouse demos to ADGF_TESTING
[01:02] GitHub121 (GitHub121@192.30.252.34) left #scummvm.
[01:08] --> dafioram joined #scummvm.
[01:11] <dafioram> snover: I was unable to apply the patch previously because I was going off of what I saw on the trace rather than from a disasm. Not sure why though.
[01:12] <snover> trace enters functions
[01:12] <snover> trace skips jumps
[01:12] <snover> trace is good for nothing other than tracing :)
[01:13] <dafioram> so i can get the patch to apply now, but its not quite the right thing
[01:13] <snover> skips-or-follows jumps, depending upon the condition*

[01:17] <dafioram> so it shows the patch getting applied right as the game starts at the main screen
[01:17] <dafioram> so I thought well maybe it happens more than once, so I changed the number to 2, then to 4, then to 20...
[01:18] <dafioram> so when I start it applies all the patches and then doesn't fix the bug
[01:18] <dafioram> so it is either somewhere else I should be making changes or my implementation
[01:20] <snover> when you `disasm` the function when the patch applies does it look how you expect?
[01:21] <dafioram> no
[01:24] <snover> then your patch is wrong :)
[01:25] <snover> or maybe
[01:25] <snover> then your patch is wrong :(
[01:26] <dafioram> well somethings wrong. It does get applied though. So maybe it is finding more than one match?
[01:26] <snover> it is possible, if your signature is not specific enough, that it is finding the same instructions somewhere else
[01:26] <-- noobineer left irc: Quit: Leaving
[01:27] <dafioram> what does the magic word do again?
[01:29] <snover> it is used by a quick-scanning algorithm to see if the patcher should even bother to try to apply the full patch
[01:30] <snover> looking for a 4-byte match is much faster than looking for a match of an entire patch, so the patcher can skip trying to search for the entire signature if not even the magicdword content (the next 4 bytes after SIG_MAGICDWORD) can be found
[01:30] <snover> entire patch signature*
[01:30] <dafioram> got it
[01:30] <dafioram> ill expand my signature
[01:36] <-- Lightkey left irc: Ping timeout: 246 seconds
[01:38] --> Littleboy joined #scummvm.
[01:38] #scummvm: mode change '+o Littleboy' by ChanServ!ChanServ@services.
[01:46] <snover> time to get started on Rama. or RAMA. however the heck you spell it. nobody seems to be able to decide.
[01:49] --> Lightkey joined #scummvm.
[01:51] <snover> oh boy hm. apples released xcode 9. do i upgrade? dare i upgrade?
[01:52] --> _sev joined #scummvm.
[01:52] #scummvm: mode change '+o _sev' by ChanServ!ChanServ@services.
[01:53] <-- _sev_ left irc: Ping timeout: 240 seconds
[01:56] <snover> on paper it looks pretty cool.
[01:57] <dafioram> first book was good
[01:59] <-- Dominus left irc: Ping timeout: 260 seconds
[02:00] --> Dominus joined #scummvm.
[02:01] <snover> custom save game format like phant1. boo.
[02:03] <snover> oh dear. might need to&disable this custom save game format. if thats even possible.
[02:04] <snover> theyre trying to serialise object IDs.
[02:05] <snover> i sure hope thats not intentional.
[02:20] <snover> bleh! it totally is.
[02:20] <snover> its trying to serialise all of the global vars.
[02:20] --> GitHub195 joined #scummvm.
[02:20] <GitHub195> [scummvm] dafioram opened pull request #1026: SCI32: Fixed pointer color when quitting for phant1 (master...phant1-redpointerpatch) https://git.io/v5ptB
[02:20] GitHub195 (GitHub195@192.30.252.45) left #scummvm.
[02:20] <snover> i guess i am going to see what happens if i replace this entire serialisation routine with a call to kSaveGame :)
[02:22] --> GitHub122 joined #scummvm.
[02:22] <GitHub122> [scummvm] dreammaster pushed 1 new commit to master: https://git.io/v5ptu
[02:22] <GitHub122> scummvm/master 00db751 Paul Gilbert: TITANIC: DE: Sound changes for Bomb
[02:22] GitHub122 (GitHub122@192.30.252.35) left #scummvm.
[02:26] <-- CHCl3 left irc: Quit: Saliendo

[02:47] <-- dreammaster left irc:
[02:50] --> GitHub47 joined #scummvm.
[02:50] <GitHub47> [scummvm] dreammaster pushed 1 new commit to master: https://git.io/v5pq0
[02:50] <GitHub47> scummvm/master 37d0b40 Paul Gilbert: TITANIC: DE: Adding German translations
[02:50] GitHub47 (GitHub47@192.30.252.34) left #scummvm.
[02:50] <snover> sneaky.
[02:52] --> CHCl3 joined #scummvm.
[03:00] <-- CHCl3 left irc: Remote host closed the connection
[04:24] <-- dafioram left irc: Quit: Leaving
[04:33] --> ignalina joined #scummvm.
[04:36] <-- ignalina left irc: Client Quit
[05:19] --> kurtwr2 joined #scummvm.
[05:20] <-- kurtwr left irc: Ping timeout: 260 seconds
[05:23] --> GitHub155 joined #scummvm.
[05:23] <GitHub155> [scummvm] bgK pushed 2 new commits to master: https://git.io/v5pGm
[05:23] <GitHub155> scummvm/master 56b744f Bastien Bouclet: MOHAWK: Riven: Plug memory leak when saving...
[05:23] <GitHub155> scummvm/master 661487c Bastien Bouclet: MOHAWK: Riven: Move the water effect to its own class...
[05:23] GitHub155 (GitHub155@192.30.252.35) left #scummvm.
[05:24] <snover> bgK: do you reckon that the default value of DisposeAfterUse parameters should be removed so that callers dont accidentally create leaks just by not providing an argument?
[05:25] <bgK> snover: my thoughts exactly!
[05:25] <bgK> I was planning to do a PR removing the default value
[05:25] <bgK> (but not this morning)
[05:25] <snover> +1 approved from me already :)
[06:12] Nick change: Stormkeeper|2 -> Storm-AFK
[06:55] --> waltervn joined #scummvm.
[06:55] #scummvm: mode change '+o waltervn' by ChanServ!ChanServ@services.
[06:57] <-- _sev left irc: Quit: This computer has gone to sleep
[06:58] --> _sev joined #scummvm.
[06:58] <-- _sev left irc: Changing host
[06:58] --> _sev joined #scummvm.
[06:58] #scummvm: mode change '+o _sev' by ChanServ!ChanServ@services.
[07:28] <-- kurtwr2 left irc:
[07:32] --> kurtwr joined #scummvm.
[07:49] <-- TMM left irc: Quit: Ex-Chat
[07:55] --> Strangerke|work joined #scummvm.
[07:55] <Strangerke|work> hi guys
[08:33] <-- LittleToonCat left irc: Remote host closed the connection
[08:42] --> _sev|work joined #scummvm.
[08:42] <-- _sev|work left irc: Changing host
[08:42] --> _sev|work joined #scummvm.
[08:42] #scummvm: mode change '+o _sev|work' by ChanServ!ChanServ@services.
[08:46] <-- _sev|work left irc: Client Quit
[08:55] --> _sev|work joined #scummvm.
[08:55] #scummvm: mode change '+o _sev|work' by ChanServ!ChanServ@services.
[08:56] <madmoose> Strangerke|work: Morning
[08:58] <-- _sev|work left irc: Client Quit
[09:09] --> _sev|work joined #scummvm.
[09:09] #scummvm: mode change '+o _sev|work' by ChanServ!ChanServ@services.
[09:09] <-- _sev|work left irc: Client Quit
[09:26] --> TMM joined #scummvm.
[09:26] #scummvm: mode change '+o TMM' by ChanServ!ChanServ@services.
[09:49] <-- TMM left irc: Quit: Ex-Chat
[10:40] --> _sev|work joined #scummvm.
[10:40] #scummvm: mode change '+o _sev|work' by ChanServ!ChanServ@services.
[10:42] --> GitHub97 joined #scummvm.
[10:42] <GitHub97> [scummvm] dreammaster pushed 2 new commits to master: https://git.io/v5p1O
[10:42] <GitHub97> scummvm/master 7a184f0 Paul Gilbert: TITANIC: DE: Add translations for loadSound calls
[10:42] <GitHub97> scummvm/master a7479b4 Paul Gilbert: TITANIC: DE: Add translations for playGlobalSound calls
[10:42] GitHub97 (GitHub97@192.30.252.35) left #scummvm.
[10:46] --> ny00123 joined #scummvm.
[11:29] <-- _sev|work left irc: Quit: This computer has gone to sleep
[11:32] --> _sev|work joined #scummvm.
[11:32] <-- _sev|work left irc: Changing host
[11:32] --> _sev|work joined #scummvm.
[11:32] #scummvm: mode change '+o _sev|work' by ChanServ!ChanServ@services.
[11:58] --> CHCl3 joined #scummvm.
[11:59] --> t0by joined #scummvm.
[11:59] #scummvm: mode change '+o t0by' by ChanServ!ChanServ@services.
[12:32] <-- _sev|work left irc: Quit: This computer has gone to sleep
[12:34] --> _sev|work joined #scummvm.
[12:34] #scummvm: mode change '+o _sev|work' by ChanServ!ChanServ@services.
[12:34] <-- _sev|work left irc: Client Quit
[12:36] --> jamm joined #scummvm.
[12:36] <-- jamm left irc: Changing host
[12:36] --> jamm joined #scummvm.
[12:37] --> _sev|work joined #scummvm.
[12:37] #scummvm: mode change '+o _sev|work' by ChanServ!ChanServ@services.
[12:38] <-- _sev|work left irc: Client Quit
[12:39] --> _sev|work joined #scummvm.
[12:39] <-- _sev|work left irc: Changing host
[12:39] --> _sev|work joined #scummvm.
[12:39] #scummvm: mode change '+o _sev|work' by ChanServ!ChanServ@services.
[12:41] <-- _sev|work left irc: Client Quit
[12:41] --> _sev|work joined #scummvm.
[12:41] <-- _sev|work left irc: Changing host
[12:41] --> _sev|work joined #scummvm.
[12:41] #scummvm: mode change '+o _sev|work' by ChanServ!ChanServ@services.
[12:43] <-- _sev|work left irc: Client Quit
[13:06] --> _sev|work joined #scummvm.
[13:06] #scummvm: mode change '+o _sev|work' by ChanServ!ChanServ@services.
[13:13] --> Littleboy joined #scummvm.
[13:13] #scummvm: mode change '+o Littleboy' by ChanServ!ChanServ@services.
[13:50] <-- t0by left irc: Read error: Connection reset by peer
[14:12] <-- ny00123 left irc: Quit: Leaving
[14:13] <-- _sev|work left irc: Quit: This computer has gone to sleep
[14:21] #scummvm: mode change '+o wjp' by ChanServ!ChanServ@services.
[14:25] --> _sev|work joined #scummvm.
[14:25] #scummvm: mode change '+o _sev|work' by ChanServ!ChanServ@services.
[14:31] <-- _sev|work left irc: Quit: This computer has gone to sleep
[14:49] --> t0by joined #scummvm.
[14:49] #scummvm: mode change '+o t0by' by ChanServ!ChanServ@services.
[15:03] --> Henke37 joined #scummvm.
[15:05] --> _sev|work joined #scummvm.
[15:05] #scummvm: mode change '+o _sev|work' by ChanServ!ChanServ@services.
[15:29] --> Begasus joined #scummvm.
[15:30] <-- _sev|work left irc: Quit: This computer has gone to sleep
[15:31] --> _sev|work joined #scummvm.
[15:31] <-- _sev|work left irc: Changing host
[15:31] --> _sev|work joined #scummvm.
[15:31] #scummvm: mode change '+o _sev|work' by ChanServ!ChanServ@services.
[15:31] <-- CHCl3 left irc: Remote host closed the connection
[15:32] --> Begas_VBox joined #scummvm.
[16:06] <-- jamm left irc: Ping timeout: 246 seconds
[16:22] --> LittleToonCat joined #scummvm.
[16:30] --> ajax16384 joined #scummvm.
[16:30] #scummvm: mode change '+o ajax16384' by ChanServ!ChanServ@services.
[17:00] --> m_kiewitz joined #scummvm.
[17:00] #scummvm: mode change '+o m_kiewitz' by ChanServ!ChanServ@services.
[17:28] <-- _sev|work left irc: Quit: This computer has gone to sleep
[17:33] --> CHCl3 joined #scummvm.
[17:43] --> Farmboy0 joined #scummvm.
[17:44] <-- Farmboy0 left irc: Changing host
[17:44] --> Farmboy0 joined #scummvm.
[17:59] --> Strangerke_ joined #scummvm.
[18:01] <-- Strangerke left irc: Ping timeout: 240 seconds
[18:01] Nick change: Strangerke_ -> Strangerke
[18:09] <-- CHCl3 left irc: Ping timeout: 240 seconds
[18:13] --> GitHub199 joined #scummvm.
[18:13] <GitHub199> [scummvm] bgK opened pull request #1027: COMMON: Remove the DisposeAfterUse default value from dynamic write memory streams constructors (master...memstream-default-arg) https://git.io/v5hXL
[18:13] GitHub199 (GitHub199@192.30.252.40) left #scummvm.
[18:23] --> CHCl3 joined #scummvm.
[18:25] <-- CHCl3 left irc: Remote host closed the connection
[18:36] --> _sev|work joined #scummvm.
[18:36] #scummvm: mode change '+o _sev|work' by ChanServ!ChanServ@services.
[18:38] --> GitHub130 joined #scummvm.
[18:38] <GitHub130> [scummvm] csnover pushed 1 new commit to master: https://git.io/v5hDk
[18:38] <GitHub130> scummvm/master 1515bb3 Colin Snover: SCI: Fix detection of end of audio map & entry size in SCI32...
[18:38] GitHub130 (GitHub130@192.30.252.42) left #scummvm.
[18:55] --> GitHub58 joined #scummvm.
[18:55] <GitHub58> [scummvm] wjp pushed 5 new commits to master: https://git.io/v5hSM
[18:55] <GitHub58> scummvm/master 6a7d432 Willem Jan Palenstijn: DIRECTOR: Skip SearchMan detour in fallback detection
[18:55] <GitHub58> scummvm/master 6bea267 Willem Jan Palenstijn: SLUDGE: Skip SearchMan detour in fallback detection
[18:55] <GitHub58> scummvm/master ca82bf6 Willem Jan Palenstijn: CGE: Clean up SearchMan after fallbackDetect
[18:55] GitHub58 (GitHub58@192.30.252.42) left #scummvm.
[18:55] --> GitHub89 joined #scummvm.
[18:55] <GitHub89> [scummvm] wjp closed pull request #1024: Clean up use of SearchMan in fallback detection (master...detection_searchman) https://git.io/v5NRq
[18:55] GitHub89 (GitHub89@192.30.252.45) left #scummvm.
[19:02] --> TMM joined #scummvm.
[19:02] #scummvm: mode change '+o TMM' by ChanServ!ChanServ@services.
[19:10] <-- edheldil left irc: Ping timeout: 246 seconds
[19:22] --> edheldil joined #scummvm.
[19:24] --> frankyboy_ joined #scummvm.
[19:25] --> girafe joined #scummvm.
[19:32] <-- vv222 left irc: Quit: reboot
[19:34] --> vv222 joined #scummvm.
[19:36] <-- _sev|work left irc: Quit: This computer has gone to sleep
[19:53] <-- Begas_VBox left irc: Quit: Vision[0.10.1]: i've been blurred!
[19:53] <-- Begasus left irc: Quit: Ex-Chat
[20:38] <-- waltervn left irc: Quit: Leaving
[20:39] <-- ajax16384 left irc: Read error: Connection reset by peer
[20:45] --> criezy joined #scummvm.
[20:45] #scummvm: mode change '+o criezy' by ChanServ!ChanServ@services.
[20:57] Nick change: Storm-AFK -> Stormkeeper
[21:01] <-- Henke37 left irc: Quit: ERR_SHUTDOWN
[21:10] <-- frankyboy_ left irc: Remote host closed the connection
[21:12] <-- Farmboy0 left irc: Remote host closed the connection
[22:02] --> CHCl3 joined #scummvm.
[22:03] <-- CHCl3 left irc: Read error: Connection reset by peer
[22:03] --> CHCl3 joined #scummvm.
[22:38] <-- Cheeseness left irc: Read error: No route to host
[22:39] --> Cheeseness joined #scummvm.
[22:48] <criezy> Grabing the mouse is suppose to force the pointer to stay in the ScummVM window and make it impossible to click outside of it (and lose the focus) right?
[22:48] <criezy> If so SDL2 is not making a very good job at it on macOS X :(
[22:49] <snover> yeah& it gets a little bouncy at the edges&
[22:49] <criezy> Yes, and on the bottom right corner you can actually click outside the window.
[22:50] <criezy> Which is possibly related to the window not being a rectangle but having slighly rounded corners.
[22:50] <snover> heh heh.
[22:50] <snover> whoops.
[22:51] <snover> heres to that Qt backend. i trust them much more than sdl folks.
[22:52] <criezy> Before diving back into that I'd like to first resume my work on the aspect ratio correction.
[22:53] <snover> of course. all in due time :)
[22:53] <criezy> And then also on the OpenGL shaders.
[22:53] <criezy> In due time might be in quite a while :P
[22:55] <snover> right around the time were finally allowed to use C++11 ;)
[22:56] <-- t0by left irc: Remote host closed the connection
[22:57] <snover> wow, i did not know that default1x worked that way. thats even crazier than what i thought it did since i never use game-specific options :)
[22:58] <snover> but it explains how i managed to somehow get hq2x scaling of scl32 once. i never did figure out what id done to let that happen.
[22:58] <criezy> This is probably documented somewhere.
[22:58] <criezy> Maybe.

[22:59] <criezy> It sort of is: http://wiki.scummvm.org/index.php/User_Manual/Configuring_a_game_in_ScummVM#Graphics_tab
[23:00] <-- CHCl3 left irc: Ping timeout: 264 seconds
[23:01] <-- m_kiewitz left irc: Read error: Connection reset by peer
[23:01] <snover> do you know how that came about?
[23:04] <criezy> If I ever knew I don't remember. This has been like this for a while.
[23:04] <criezy> I think the idea was maybe to default laucher and all games to 640x400 or 640x480 at a time when we did not support games with a higher resolution than that and screen size were more limitted than now.
[23:07] <-- girafe left irc: Read error: Connection reset by peer
[23:20] --> CHCl3 joined #scummvm.
[23:27] --> GitHub45 joined #scummvm.
[23:27] <GitHub45> [scummvm] dafioram opened pull request #1028: IMAGE: Fix memory leak in writePNG (master...image_mem-fix) https://git.io/v5jno
[23:27] GitHub45 (GitHub45@192.30.252.42) left #scummvm.
[23:28] --> dafioram joined #scummvm.
[23:30] <snover> argh.
[23:30] <dafioram> snover: PR1026 is ready for your toughest questions
[23:30] <snover> 1028 is full of harder questions
[23:30] <snover> :)
[23:46] --> dreammaster joined #scummvm.
[23:46] #scummvm: mode change '+o dreammaster' by ChanServ!ChanServ@services.
[23:55] --> Stormkeeper|2 joined #scummvm.
[23:57] <-- Stormkeeper left irc: Ping timeout: 260 seconds
[00:00] --- Thu Sep 21 2017