[Back to Index]

[00:37] <-- Harekiet left irc: Read error: Connection reset by peer
[00:39] --> Harekiet joined #scummvm.
[00:39] <-- SylvainTV left irc: Excess Flood
[00:39] --> SylvainTV joined #scummvm.
[00:39] #scummvm: mode change '+o SylvainTV' by ChanServ!ChanServ@services.

[00:49] <-- SylvainTV left irc: Read error: Connection reset by peer
[00:57] <-- Henke37 left irc: Quit: ERR_SHUTDOWN
[01:21] <-- Dominus left irc: Ping timeout: 246 seconds
[01:22] --> Dominus joined #scummvm.
[03:21] <-- ST1 left irc: Quit: Leaving.
[03:40] --> LeChuck joined #scummvm.
[03:47] --> ST joined #scummvm.
[03:47] #scummvm: mode change '+o ST' by ChanServ!ChanServ@services.
[04:02] --> Poly-C joined #scummvm.
[04:03] <-- Polynomial-C left irc: Ping timeout: 244 seconds
[05:05] --> edheldil_ joined #scummvm.
[05:10] <-- edheldil_ left irc: Ping timeout: 250 seconds
[05:20] <-- Axy left irc: Read error: Connection reset by peer
[06:26] <-- Satyricon left irc: Ping timeout: 276 seconds
[06:28] <-- madmoose left irc: Ping timeout: 276 seconds
[06:28] --> Satyricon joined #scummvm.
[06:28] --> madmoose joined #scummvm.
[06:35] --> john joined #scummvm.
[06:35] <-- {V} left irc: Ping timeout: 260 seconds
[06:36] Nick change: john -> Guest54857
[06:36] --> {V} joined #scummvm.
[06:58] --> waltervn joined #scummvm.
[06:58] #scummvm: mode change '+o waltervn' by ChanServ!ChanServ@services.
[07:20] --> ny00123 joined #scummvm.
[07:25] --> ajax16384 joined #scummvm.
[07:25] #scummvm: mode change '+o ajax16384' by ChanServ!ChanServ@services.
[07:26] --> Strangerke|work joined #scummvm.
[07:26] <Strangerke|work> hi guys
[07:30] <P2E> yo
[07:30] <P2E> hey, what do folks think of broken sword 3/4/5
[07:35] <Harekiet> we don't think about them, they're to be forgotten...
[07:36] <LePhilousophe> even the last one?
[07:36] <Harekiet> Haven't tried that one yet
[07:36] <Harekiet> wasn't htat episosal
[07:38] --> uruk-hai joined #scummvm.
[07:38] #scummvm: mode change '+o uruk-hai' by ChanServ!ChanServ@services.
[07:40] <P2E> basically there's a deal to get 1-5 for 9 bucks
[07:40] <P2E> I enjoyed 1, I don't know that I made it through 2
[07:40] <P2E> also, 3/4 don't run on linux
[07:40] <uruk-hai> good morning all :)
[07:41] <P2E> at least, not inside steam?
[07:52] <Harekiet> Only managed to finish the wolf among us as far as episodic games go
[07:58] <-- uruk-hai left irc: Read error: Connection reset by peer
[08:00] --> Tkachov_ joined #scummvm.
[08:02] --> Mia joined #scummvm.
[08:03] --> m_kiewitz joined #scummvm.
[08:03] <-- m_kiewitz left irc: Changing host
[08:03] --> m_kiewitz joined #scummvm.
[08:03] #scummvm: mode change '+o m_kiewitz' by ChanServ!ChanServ@services.
[08:12] <-- Harekiet left irc: Remote host closed the connection
[08:13] --> Harekiet joined #scummvm.
[08:29] --> omer_mor joined #scummvm.
[08:30] <omer_mor> hi
[08:30] <omer_mor> i've got a question about the SCI script patcher
[08:30] <m_kiewitz> ?
[08:30] <omer_mor> Can it also handle patches to the heap resources?
[08:31] <m_kiewitz> it should
[08:31] <m_kiewitz> in fact i think there are a few heap patches already
[08:32] <omer_mor> I skimmed through the patches and didn't find any
[08:32] <omer_mor> but perhaps I overlooked
[08:32] <omer_mor> I'm trying to write a patch for https://sourceforge.net/p/scummvm/bugs/7086/
[08:32] <omer_mor> I was able to write a fix in SCI Companion, and would like to try and write one in scummvm as well
[08:34] <-- tsoliman left irc: Ping timeout: 244 seconds
[08:34] <m_kiewitz> larry5SignatureGermanEndingPattiTalker is a heap patch
[08:34] --> tsoliman joined #scummvm.
[08:34] #scummvm: mode change '+o tsoliman' by ChanServ!ChanServ@services.
[08:35] <m_kiewitz> kq5SignatureWitchCageInit is another one
[08:36] <omer_mor> Great - thanks! I'll take a look shortly (going to pick my kid from school).
[08:48] --> Henke37 joined #scummvm.
[09:19] --> uruk-hai joined #scummvm.
[09:19] #scummvm: mode change '+o uruk-hai' by ChanServ!ChanServ@services.
[09:27] <-- TMM left irc: Quit: Ex-Chat
[09:49] <m_kiewitz> omer_mor: if you can, please check the multilingual versions too. and if you can't, i can do that for you
[10:06] <omer_mor> I checked them. same bug.
[10:06] <omer_mor> I didn't check the GOG version yet. will do that as well.
[10:06] <omer_mor> bbl
[10:11] --> h00ligan joined #scummvm.
[10:11] #scummvm: mode change '+o h00ligan' by ChanServ!ChanServ@services.
[10:14] <-- ajax16384 left irc: Ping timeout: 244 seconds
[10:30] --> TMM joined #scummvm.
[11:12] <m_kiewitz> omer_mor: i expected that. But what I meant to say is that you should make sure that the patch applies to all of those versions.
[11:12] <m_kiewitz> In the worst case GOG maybe got a fan-patched script. In that case I would actually ignore it unless the same patch applies directly w/o modifications
[11:27] --> Henke37b joined #scummvm.
[11:31] <-- Henke37 left irc: Ping timeout: 252 seconds
[11:40] --> WinterGrascph joined #scummvm.
[11:40] #scummvm: mode change '+v WinterGrascph' by ChanServ!ChanServ@services.
[11:40] <m_kiewitz> anyone has seen "Island of Lost Souls" (1932)?
[11:42] <-- Tkachov_ left irc: Quit: Leaving
[11:49] <uruk-hai> m_kiewitz, how has it came into your attention? :D it's quite an antique movie
[11:49] <m_kiewitz> zavvi sells the master of cinema steelbook for effectively 6 pounds only :P
[11:49] <m_kiewitz> masters
[11:49] <m_kiewitz> have you seen it?
[11:50] <-- WinterGrascph left irc: Ping timeout: 252 seconds
[11:50] --> ThirdChoice joined #scummvm.
[11:54] <-- h00ligan left irc: Ping timeout: 244 seconds
[11:54] --> h00ligan joined #scummvm.
[11:54] #scummvm: mode change '+o h00ligan' by ChanServ!ChanServ@services.
[11:55] <-- ThirdChoice left irc: Ping timeout: 246 seconds
[12:01] --> WinterGrascph joined #scummvm.
[12:01] #scummvm: mode change '+v WinterGrascph' by ChanServ!ChanServ@services.
[12:01] <Strangerke|work> hey WinterGrascph :)
[12:01] <WinterGrascph> Sup ^^
[12:02] <Strangerke|work> You should advertise a bit about your progress :P
[12:14] <Strangerke|work> ok, I'll advertise for you then.
[12:15] <Strangerke|work> Guys, WinterGrascph managed to load the map and display the dungeon view in DM :)
[12:21] <_sev> cool
[12:21] <_sev> very cool
[12:21] <_sev> WinterGrascph: congrats
[12:21] <WinterGrascph> Thanks ^^
[12:47] <uruk-hai> nice job, man! :)
[12:47] <uruk-hai> we are waiting for the screenshots! :P
[12:50] --> Strangerke|work_ joined #scummvm.
[12:53] <-- Strangerke|work left irc: Ping timeout: 250 seconds
[13:08] --> parwana joined #scummvm.
[13:19] --> Littleboy joined #scummvm.
[13:19] #scummvm: mode change '+o Littleboy' by ChanServ!ChanServ@services.
[13:23] <rootfather> nice job WinterGrascph
[13:23] <rootfather> screenshots and a blog update maybe? :D
[13:26] --> salty-horse joined #scummvm.
[13:26] <-- salty-horse left irc: Changing host
[13:26] --> salty-horse joined #scummvm.
[13:26] #scummvm: mode change '+o salty-horse' by ChanServ!ChanServ@services.
[13:32] --> blorente joined #scummvm.
[13:32] --> blorente1 joined #scummvm.
[13:32] <-- blorente1 left irc: Client Quit
[13:32] #scummvm: mode change '+v blorente' by ChanServ!ChanServ@services.
[13:32] <blorente> Evening :)
[13:38] <Strangerke|work_> G'day blorente
[13:40] <blorente> Strangerke|work_, o/
[13:41] <blorente> How are you doing?
[13:42] <Strangerke|work_> tgif
[13:42] <Strangerke|work_> what about you?
[13:43] <blorente> sif
[13:43] <blorente> stands for "Shoot! it's Frriday already! I have to work!"
[13:44] <blorente> xD
[13:44] <blorente> I managed to get a recursive segfault that crashed my computer a while ago
[13:45] <Strangerke|work_> oh , ok. I thought it stands for "Smoke It, Fucker!"
[13:45] <Strangerke|work_> Which was fine too, imo :P
[13:46] <blorente> Hahaha, maybe
[14:09] --> GitHub87 joined #scummvm.
[14:09] <GitHub87> [scummvm] sev- closed pull request #758: androidsdl port (master...master) https://git.io/vr0iP
[14:09] GitHub87 (GitHub87@192.30.252.34) left #scummvm.
[14:09] --> GitHub102 joined #scummvm.
[14:09] <GitHub102> [scummvm] sev- pushed 5 new commits to master: https://git.io/vruFL
[14:09] <GitHub102> scummvm/master 961976f lubomyr: ANDROIDSDL: add androidsdl backend
[14:09] <GitHub102> scummvm/master 5a0fc8e lubomyr: ANDROIDSDL: add image banner.png for androidTV
[14:09] <GitHub102> scummvm/master 471a8f9 lubomyr: ANDROIDSDL: updated banner.png image
[14:09] GitHub102 (GitHub102@192.30.252.40) left #scummvm.
[14:11] --> GitHub33 joined #scummvm.
[14:11] <GitHub33> [scummvm] sev- pushed 4 new commits to branch-1-8: https://git.io/vruFi
[14:11] <GitHub33> scummvm/branch-1-8 9b00214 lubomyr: ANDROIDSDL: add androidsdl backend
[14:11] <GitHub33> scummvm/branch-1-8 f3fd7cb lubomyr: ANDROIDSDL: add image banner.png for androidTV
[14:11] <GitHub33> scummvm/branch-1-8 16b3ee6 lubomyr: ANDROIDSDL: updated banner.png image
[14:11] GitHub33 (GitHub33@192.30.252.34) left #scummvm.
[14:12] --> GitHub65 joined #scummvm.
[14:12] <GitHub65> [scummvm] sev- pushed 1 new commit to branch-1-8: https://git.io/vruFy
[14:12] <GitHub65> scummvm/branch-1-8 99497fb Eugene Sandulenko: NEWS: Mention Android SDL port
[14:12] GitHub65 (GitHub65@192.30.252.45) left #scummvm.
[14:12] --> GitHub93 joined #scummvm.
[14:12] <GitHub93> [scummvm] sev- pushed 1 new commit to master: https://git.io/vruFd
[14:12] <GitHub93> scummvm/master 96c7860 Eugene Sandulenko: NEWS: Mention Android SDL port
[14:12] GitHub93 (GitHub93@192.30.252.45) left #scummvm.
[14:13] --> Tkachov_ joined #scummvm.
[14:16] --> Strangerke_ joined #scummvm.
[14:18] <-- Strangerke left irc: Ping timeout: 260 seconds
[14:18] Nick change: Strangerke_ -> Strangerke
[14:21] <WinterGrascph> rootfather: The blogpost and the screenshots are coming:)
[14:46] <-- uruk-hai left irc: Read error: Connection reset by peer
[15:02] <-- h00ligan left irc: Quit: Leaving
[15:11] <-- parwana left irc: Quit: Connection closed for inactivity
[15:30] <-- Tkachov_ left irc: Quit: Leaving
[15:37] <-- TMM left irc: Quit: Ex-Chat
[15:40] <-- Strangerke|work_ left irc: Quit: Bbl
[15:40] <-- Guest54857 left irc: Read error: Connection reset by peer
[15:40] --> LordHoto joined #scummvm.
[15:40] #scummvm: mode change '+o LordHoto' by ChanServ!ChanServ@services.
[15:41] --> ajax16384 joined #scummvm.
[15:41] #scummvm: mode change '+o ajax16384' by ChanServ!ChanServ@services.
[15:52] <-- ced117 left irc: Quit: Quitte
[16:08] --> onntce joined #scummvm.
[16:16] <-- Poly-C left irc: Quit: GNU/Linux, because I'd rather own a free OS than steal one that's not worth paying for.
[16:19] <-- onntce left irc: Ping timeout: 260 seconds
[16:20] --> Polynomial-C joined #scummvm.
[16:23] --> GitHub27 joined #scummvm.
[16:23] <GitHub27> [scummvm] sev- pushed 1 new commit to branch-1-8: https://git.io/vrznx
[16:23] <GitHub27> scummvm/branch-1-8 a5aecfe Christoph Korn: SHERLOCK: Add format to fix compile error...
[16:23] GitHub27 (GitHub27@192.30.252.45) left #scummvm.
[16:53] --> biaxvb joined #scummvm.
[16:57] --> WooShell joined #scummvm.
[16:57] <WooShell> meow =^.^=
[17:15] <Strangerke> https://www.youtube.com/watch?v=QNwCojCJ3-Q
[17:15] <Strangerke> hi WooShell
[17:33] <-- biaxvb left irc: Remote host closed the connection
[17:44] --> snover joined #scummvm.
[17:44] #scummvm: mode change '+o snover' by ChanServ!ChanServ@services.
[17:49] <LordHoto> snover!
[17:52] --> john joined #scummvm.
[17:52] Nick change: john -> Guest38607
[17:59] <snover> hi
[18:03] <omer_mor> hi
[18:03] <omer_mor> I need some more help with the SCI patching system
[18:03] <snover> sorry for the extended absence
[18:03] <omer_mor> anyone here?
[18:03] <m_kiewitz> ?
[18:04] <omer_mor> my first attempt was to simply replace one WORD with another
[18:04] <omer_mor> and I managed to pull this off
[18:04] <m_kiewitz> and then?
[18:04] <omer_mor> however it's not the right way to go: I need to add a WORD to the heap, which would result in offsets moving around in the matching script
[18:04] --> SylvainTV joined #scummvm.
[18:04] #scummvm: mode change '+o SylvainTV' by ChanServ!ChanServ@services.
[18:05] <m_kiewitz> you can't add bytes at all
[18:05] <m_kiewitz> you can only modify bytes
[18:05] <m_kiewitz> so in case you need to add more instructions, you need a way to make space for them
[18:05] <omer_mor> in the heap, or also in scripts?
[18:05] <m_kiewitz> by for example optimization
[18:06] <m_kiewitz> in the heap, you can't really add anything
[18:07] <omer_mor> so there's nothing (trivial) that can be done here?
[18:07] <m_kiewitz> well what do you want to do exactly?
[18:07] <omer_mor> I described it in the bug, but here goes:
[18:07] <m_kiewitz> is there a number of words and you need another word?
[18:07] <omer_mor> the Teller class is responsible of showing dialog trees
[18:08] <omer_mor> a Teller instance has an array of possible messages
[18:08] <omer_mor> the Teller::showDialog is overridden by Teller instances
[18:09] <omer_mor> in my case it's egoTell::showDialog
[18:09] <m_kiewitz> hmmm that's a problem I guess in case a script patch is not possible / too difficult
[18:09] <omer_mor> this showDialog will check the game state and will construct an interleaved array of messages + flags. According to these flags, the Teller will decide which message to show
[18:10] <m_kiewitz> unless there is some left-over number in there, that isn't actually used
[18:10] <omer_mor> I thought there was a left-over number, but I was wrong
[18:10] <omer_mor> this number is used after all.
[18:12] <m_kiewitz> so it's the last block of numbers in the local array?
[18:12] <m_kiewitz> 4 "0" numbers are following it, are those used?
[18:12] <omer_mor> yes, they are used
[18:12] <omer_mor> it would be a pointer the the previous array
[18:13] <m_kiewitz> and are there multiple instances, that do use that array?
[18:13] <m_kiewitz> or is there only 1?
[18:13] <m_kiewitz> in case there is only 1, then maybe the script could get patched instead
[18:14] <omer_mor> I think it's only egoTell that use this array
[18:14] <omer_mor> but the parent class (Teller) is also accessing it
[18:14] <m_kiewitz> and both are searching through it?
[18:15] <omer_mor> I think only the base class
[18:15] <m_kiewitz> and the array has to start with a "0"?
[18:15] <m_kiewitz> base class would be a nightmare to patch
[18:15] <-- LordHoto left irc: Quit: bbl
[18:17] <omer_mor> i'm not sure it has to start with 0
[18:17] <omer_mor> I can try to patch the 0 and see what happens
[18:17] <omer_mor> but i'm not optimistic
[18:17] <omer_mor> all of these messages array I saw began with 0 and ended with 999
[18:18] <m_kiewitz> which text does it take for for example -41?
[18:19] <omer_mor> "Greet"
[18:19] --> GitHub97 joined #scummvm.
[18:19] <GitHub97> [scummvm] sev- pushed 2 new commits to master: https://git.io/vrz6e
[18:19] <GitHub97> scummvm/master 1c48025 Eugene Sandulenko: AUTHORS: Update 1/2. Main contributors, including SCI team
[18:19] <GitHub97> scummvm/master 0009899 Eugene Sandulenko: AUTHORS: Update 2/2. Patch contributors. (Phew!)
[18:19] GitHub97 (GitHub97@192.30.252.40) left #scummvm.
[18:19] <m_kiewitz> does it change that to "41"?
[18:20] <m_kiewitz> what does it do on "1"?
[18:21] <omer_mor> 1 is "Tell about Tarna"
[18:21] <omer_mor> I think the negative number has some semantic to them
[18:21] <omer_mor> not sure what it is though
[18:21] <omer_mor> numbers*
[18:21] --> GitHub113 joined #scummvm.
[18:21] <GitHub113> [scummvm] sev- pushed 1 new commit to branch-1-8: https://git.io/vrz6w
[18:21] <GitHub113> scummvm/branch-1-8 59d9709 Eugene Sandulenko: AUTHORS: Sync with master
[18:21] GitHub113 (GitHub113@192.30.252.34) left #scummvm.
[18:23] <m_kiewitz> hmm that's a problem
[18:23] <_sev> phew
[18:23] <omer_mor> thanks for the credit sev! :-)
[18:23] <_sev> it took significant amount of time
[18:24] <_sev> omer_mor: nah, thank you for your patches
[18:24] <omer_mor> now if only someone could approve my PR for Codename: Iceman....
[18:24] <omer_mor> =)
[18:24] <m_kiewitz> that array is for giving out points? or how exactly does it work out?
[18:25] <omer_mor> The array is for possible messages to display
[18:25] <omer_mor> by that Teller
[18:25] <m_kiewitz> but the text worked already? i thought it was just the points
[18:26] <omer_mor> the is also logic in showDialog that filters the messages the should be *currently* displayed. There is also logic in doChild that awards points when the message is selected by the user
[18:26] <omer_mor> the bug was that the message was never displayed
[18:27] <omer_mor> and thus the user couldn't select it, and gain the points for saying it
[18:27] <omer_mor> there is logic that determines the message should be displayed after a certain puzzle is solved (puzzle #56 - finishing the initiation)
[18:28] <m_kiewitz> so you selected that option and no dialog was shown?
[18:28] <omer_mor> this is in egoTell::showDialog
[18:28] <omer_mor> but the option is not displayed in the first place
[18:28] <omer_mor> even though showDialog asks to display it
[18:28] <omer_mor> because message -31 is not in the initial array of possible messages
[18:29] <omer_mor> (array local150 which is referenced by egoTell:curArray
[18:29] <omer_mor> )
[18:30] <omer_mor> there is a matching process going on Teller::doDialog - matching between the message that showDialog asked to display, and the curArray of possible messages
[18:31] <m_kiewitz> where does Teller:doDialog get the pointer to that array?
[18:32] <omer_mor> it's a member of the Teller class
[18:32] <omer_mor> curArray
[18:32] <omer_mor> it's all in script 23
[18:33] <omer_mor> curArray is initialized in Teller::init
[18:33] <m_kiewitz> and who calls it?
[18:33] <omer_mor> in egoTell's case, egoTell::init is called in rm285::init
[18:33] <m_kiewitz> it seems Teller::init gets it as a parameter
[18:34] <omer_mor> (egoTell init: gOwner @local156 @local170)
[18:34] <m_kiewitz> ah that makes sense
[18:35] <m_kiewitz> wait, local170 is the end?
[18:35] <m_kiewitz> or is that storage?
[18:35] <omer_mor> local170 is a pointer to local156
[18:35] <omer_mor> (= [local170 0] @local156)
[18:36] <omer_mor> Teller:arrays is initialized with local170 which is a pointer to local156
[18:39] <omer_mor> MAYBE - we can move local170 to local172
[18:40] <omer_mor> i think only 2 bytes are used in this array
[18:40] <omer_mor> I can try to patch all usages of local170
[18:40] <omer_mor> i think it's only in 2 places
[18:41] <omer_mor> it is...
[18:41] <omer_mor> I'll try that
[18:41] <omer_mor> an address in SCI16 is 2 bytes, right?
[18:42] <omer_mor> or is it represented as segment:offset ?
[18:42] <omer_mor> with 4 bytes?
[18:42] <m_kiewitz> ?
[18:42] <m_kiewitz> we need another word?
[18:42] <omer_mor> in this line: (= [local170 0] @local156)
[18:42] <m_kiewitz> i mean doesn't it use 2 words?
[18:42] <m_kiewitz> because there are 2 words, well rather 4 words at that place?
[18:42] <omer_mor> local170 is initialized with the address of local156. address is 2 bytes or 4 bytes?
[18:42] <m_kiewitz> 2 bytes
[18:43] <m_kiewitz> but there is more after that
[18:43] <omer_mor> right...
[18:43] <m_kiewitz> hmmm right, weird. i can't find local[$ac] or anything like that
[18:43] <omer_mor> I thought local170 is 4 bytes, but it's 4 words
[18:43] <m_kiewitz> yes
[18:44] <m_kiewitz> unless of course that thing saves multiple words
[18:44] <omer_mor> ok, so I can make it 3 words and see what happens
[18:44] <m_kiewitz> can you check what's written at that spot when the code is active?
[18:44] <omer_mor> it looks like local170 is never changing
[18:44] <m_kiewitz> I mean the locals right after $aa
[18:44] <omer_mor> yes, i can
[18:45] <m_kiewitz> that would be a solution, yes. but we really need to verify that the space isn't used and that it's just dead space added by the compiler or so
[18:45] <m_kiewitz> there are only 2 references to $aa, so it would be trivial to patch (and you could even use the same patch for both and just let that patch run twice)
[18:46] <m_kiewitz> it seems the offsets are the same in all multilingual versions
[18:47] <m_kiewitz> locals themselves also look the same
[18:47] <omer_mor> 0000:0000 0000:ffd7 0000:ffb4 0000:0001
[18:48] <omer_mor> 0000:ffe2 0000:ffb3 0000:ffdf 0000:ffde
[18:48] <omer_mor> 0000:ffdd 0000:ffdc 0000:ffdb 0000:ffd6
[18:48] <omer_mor> 0000:ffb0 0000:03e7 0089:0138 0000:0000
[18:48] <omer_mor> 0000:0000 0000:0000
[18:48] <m_kiewitz> hmm looks good
[18:48] <m_kiewitz> i don't really like it but well i don't see another way
[18:49] <omer_mor> yeah, I feel the same
[18:49] <omer_mor> I'll give it a go
[18:50] <m_kiewitz> oh and its not the same instructions for $aa
[18:50] <m_kiewitz> first one is "lea local[$aa]"
[18:50] <m_kiewitz> second one is "sali local[$aa]"
[18:51] <m_kiewitz> so b3 aa
[18:52] <m_kiewitz> and 5b 02 aa
[18:52] <-- WinterGrascph left irc: Ping timeout: 276 seconds
[18:53] <m_kiewitz> ah wait and that pointer is set when exactly?
[18:53] <m_kiewitz> during ::init, I guess? when is ::init called?
[18:53] <m_kiewitz> we need to make sure, that saved games will work no matter what
[18:54] <m_kiewitz> you will probably have to overwrite local $aa in any case, so don't check that it's 0 inside the signature
[19:00] --> iskrich joined #scummvm.
[19:00] #scummvm: mode change '+v iskrich' by ChanServ!ChanServ@services.
[19:02] <omer_mor> I'm trying to replace all $aa in script 285 to $ac
[19:02] <omer_mor> there are only 2 instances which are these 2
[19:03] <omer_mor> I don't know about saved games...
[19:03] <omer_mor> static const uint16 qfg3SignatureMissingPointsLocal170[] = { SIG_MAGICDWORD, 0xaa, // 0 _START MARKER_ SIG_END }; static const uint16 qfg3PatchMissingPointsLocal170[] = { 0xac, PATCH_END };
[19:04] <omer_mor> static const uint16 qfg3SignatureMissingPointsLocal170[] = { SIG_MAGICDWORD, 0xaa, SIG_END }; static const uint16 qfg3PatchMissingPointsLocal170[] = { 0xac, PATCH_END };
[19:04] <omer_mor> will something like that work?
[19:04] --> ced117 joined #scummvm.
[19:04] <m_kiewitz> don't do this
[19:05] <m_kiewitz> first of all magic dword needs to be a dword
[19:05] <m_kiewitz> and replacing a single byte with something else isn't good anyway
[19:06] <m_kiewitz> you can check for
[19:06] <omer_mor> I actually have no idea what the magic word stands for in the pacher
[19:06] <m_kiewitz> ldi 0 -> 35h 00h
[19:06] <omer_mor> tried to understand from the comment but failed
[19:06] <omer_mor> I thought you had to include it...
[19:06] <m_kiewitz> sali local[$aa] -> b3h aah
[19:06] --> girafe joined #scummvm.
[19:07] <m_kiewitz> magic dword marks the dword to search for
[19:07] <m_kiewitz> this is done for performance
[19:07] <omer_mor> oh...
[19:07] <m_kiewitz> it needs to be fixed 4 bytes in total, that should be searched for. when its found, it will search for the exact signature around it
[19:07] <omer_mor> ok.. now i get it
[19:07] <omer_mor> I can skip it altogether I guess?
[19:08] <m_kiewitz> that above should be enough for the first one
[19:08] <m_kiewitz> no, magic dword is needed
[19:08] <m_kiewitz> if you don't mark it, then the signature will get rejected and you will get an error
[19:08] <m_kiewitz> second one
[19:09] <m_kiewitz> push -> 36h
[19:09] <m_kiewitz> lea local[$aa] -> 5bh 02h aah
[19:09] <m_kiewitz> also 4 bytes, that should work
[19:09] <omer_mor> ok
[19:09] <omer_mor> I'll try that - thanks for working it out for me...
[19:09] <omer_mor> :)
[19:12] <-- ced117 left irc: Read error: Connection reset by peer
[19:15] --> ced117__ joined #scummvm.
[19:17] --> frankyboy_ joined #scummvm.
[19:18] <-- Guest38607 left irc: Ping timeout: 276 seconds
[19:21] Nick change: ced117__ -> ced117
[19:21] <-- ced117 left irc: Changing host
[19:21] --> ced117 joined #scummvm.
[19:24] <omer_mor> it worked! :-)
[19:25] <omer_mor> I need to leave now, but I'll make a PR out of this later today or tomorrow
[19:25] <omer_mor> thanks for the help martin!
[19:25] <m_kiewitz> kk
[19:25] <m_kiewitz> thanks for patching this fla
[19:25] <m_kiewitz> flaw
[19:25] <m_kiewitz> i wanted to look into it, but had no time for it yet
[19:43] <-- snover left irc: Quit: Leaving.
[19:52] <-- ced117 left irc: Remote host closed the connection
[19:55] --> snover joined #scummvm.
[19:55] #scummvm: mode change '+o snover' by ChanServ!ChanServ@services.
[19:56] --> ced117 joined #scummvm.
[20:00] --> WinterGrascph joined #scummvm.
[20:01] --> WinterGrascph_ joined #scummvm.
[20:02] <-- blorente left irc: Quit: Probably just going to sleep.
[20:05] <-- WinterGrascph left irc: Ping timeout: 276 seconds
[20:23] <-- DJWillis left irc: Read error: Connection reset by peer
[20:24] --> DJWillis joined #scummvm.
[20:24] #scummvm: mode change '+o DJWillis' by ChanServ!ChanServ@services.
[20:28] <-- Mia left irc: Read error: Connection reset by peer
[20:43] <-- frankyboy_ left irc: Remote host closed the connection
[20:48] --> GitHub48 joined #scummvm.
[20:48] <GitHub48> [scummvm] Strangerke pushed 1 new commit to branch-1-8: https://git.io/vrgfe
[20:48] <GitHub48> scummvm/branch-1-8 7526d03 Strangerke: CREDITS - Mark Clone2727 as Retired
[20:48] GitHub48 (GitHub48@192.30.252.40) left #scummvm.
[20:49] --> GitHub51 joined #scummvm.
[20:49] <GitHub51> [scummvm] Strangerke pushed 1 new commit to master: https://git.io/vrgfZ
[20:49] <GitHub51> scummvm/master 7335c6f Strangerke: CREDITS - Mark Clone2727 as Retired
[20:49] GitHub51 (GitHub51@192.30.252.40) left #scummvm.
[20:50] --> GitHub122 joined #scummvm.
[20:50] <GitHub122> [scummvm-web] Strangerke pushed 1 new commit to master: https://github.com/scummvm/scummvm-web/commit/e3297e490eb49151e828421d5633fec7a52b354b
[20:50] <GitHub122> scummvm-web/master e3297e4 Strangerke: CREDITS - Mark Clone2727 as Retired
[20:50] GitHub122 (GitHub122@192.30.252.40) left #scummvm.
[21:01] <-- kurtwr left irc:
[21:29] Nick change: Henke37b -> henke37
[21:32] <-- ny00123 left irc: Quit: Leaving
[21:48] <-- WooShell left irc: Quit: Zu gotdy od mpy nrmy stpimf. Zu drvpmf zrsmd aogy jrt iq pt viy jrt yp yjr htpimf.
[21:55] --> LordHoto joined #scummvm.
[21:55] #scummvm: mode change '+o LordHoto' by ChanServ!ChanServ@services.
[21:58] <_sev> so...
[21:58] <_sev> tagging tim
[21:58] <_sev> time
[21:58] --> kurtwr joined #scummvm.
[21:59] <_sev> LordHoto: anything I need to be aware of before the tagging?
[22:00] <Strangerke> yeah, don't eat yellow snow!
[22:00] <-- m_kiewitz left irc: Read error: Connection reset by peer
[22:01] <_sev> ugh, good that you reminded me!
[22:02] <Strangerke> :P
[22:02] <-- ajax16384 left irc: Quit: Leaving
[22:09] --> GitHub13 joined #scummvm.
[22:09] <GitHub13> [scummvm] sev- tagged v1.8.1 at 33850b8: https://git.io/vrgOm
[22:09] <GitHub13> scummvm/v1.8.1 97c5fe4 Eugene Sandulenko: RELEASE: This is 1.8.1
[22:09] GitHub13 (GitHub13@192.30.252.40) left #scummvm.
[22:09] --> GitHub175 joined #scummvm.
[22:09] <GitHub175> [scummvm] sev- created branch-1-8-1 (+1 new commit): https://git.io/vrgOm
[22:09] <GitHub175> scummvm/branch-1-8-1 97c5fe4 Eugene Sandulenko: RELEASE: This is 1.8.1
[22:09] GitHub175 (GitHub175@192.30.252.46) left #scummvm.
[22:11] <LordHoto> _sev: I'm sure I'm the wrong person to ask here ;-).
[22:15] Topic changed on #scummvm by _sev!sev@scummvm/undead/sev: ScummVM 1.8.0 || 1.8.1 tagged || https://www.scummvm.org/faq/ || No warez, no Game Requests, read the FAQ! || Channel logs: http://logs.scummvm.org
[22:15] <_sev> LordHoto: heh
[22:16] --> m_kiewitz joined #scummvm.
[22:16] <-- m_kiewitz left irc: Changing host
[22:16] --> m_kiewitz joined #scummvm.
[22:16] #scummvm: mode change '+o m_kiewitz' by ChanServ!ChanServ@services.
[22:18] <-- salty-horse left irc: Quit: Leaving
[22:35] <-- m_kiewitz left irc: Quit: technology isn't intrinsically good or evil. It's how it's used. Like the Death Ray.
[22:52] <-- girafe left irc: Read error: Connection reset by peer
[23:11] --> Strangerke_ joined #scummvm.
[23:13] <-- Strangerke left irc: Ping timeout: 246 seconds
[23:13] Nick change: Strangerke_ -> Strangerke
[23:15] <criezy> _sev: the link in your email points to 1.8.0 (despite the text saying 1.8.1).
[23:15] <criezy> Not a big deal, this is obvious once you have clicked it so I doubt anybody will compile the 1.8.0 source code by mistake
[23:15] <criezy> and it is easy to change a 0 into a 1 in the address.
[23:16] <_sev> oh, that is these HTML emails...
[23:16] <_sev> thanks for the pointing
[23:29] <-- iskrich left irc: Ping timeout: 250 seconds
[23:43] <-- Schnabeltierchen left irc: Ping timeout: 276 seconds
[23:45] --> Schnabeltierchen joined #scummvm.
[23:52] <-- WinterGrascph_ left irc: Quit: Leaving
[23:57] <-- henke37 left irc: Quit: ERR_SHUTDOWN
[00:00] --- Sat May 21 2016