ScummVM IRC Log - 13 Jan 2018

[Back to Index]

[00:00] <-- _sev left irc: Ping timeout: 240 seconds
[00:33] --> girafe2 joined #scummvm.
[00:36] <-- girafe left irc: Ping timeout: 240 seconds
[00:50] <-- waltervn left irc: Quit: night
[00:54] <-- ccawley2011 left irc: Quit: Page closed
[01:15] <-- ignalina left irc: Quit: ignalina
[01:31] Nick change: Stormkeeper -> Storm-AFK
[02:22] --> GitHub65 joined #scummvm.
[02:22] <GitHub65> [scummvm] dreammaster pushed 1 new commit to master: https://git.io/vNZii
[02:22] <GitHub65> scummvm/master 5314675 Paul Gilbert: XEEN: Further savegame logic
[02:22] GitHub65 (GitHub65@gateway/service/github.com/x-snentrjabpodhufp) left #scummvm.
[02:23] --> Strangerke_ joined #scummvm.
[02:23] <-- ST left irc: Quit: Leaving.
[02:25] <-- Strangerke left irc: Ping timeout: 256 seconds
[02:25] Nick change: Strangerke_ -> Strangerke
[02:29] <-- Dominus left irc: Ping timeout: 260 seconds
[02:29] --> Dominus joined #scummvm.
[02:39] --> ST joined #scummvm.
[02:39] #scummvm: mode change '+o ST' by ChanServ!ChanServ@services.
[03:10] <-- Mia left irc: Quit: Leaving
[03:24] <tsoliman> snover: when an engine calls warpMouse() in the new gfxmgr code ... what coordinate system is supposed to use?
[03:24] --> jammm joined #scummvm.
[03:25] <-- jamm left irc: Read error: Connection reset by peer
[03:26] <snover> tsoliman: engines always operate in the virtual screen coordinates. (just fyi, the method is also commented.)
[03:29] <-- jammm left irc: Read error: Connection reset by peer
[03:35] <tsoliman> I can't tell if this bug is in the new gfxmgr changes or in tinsel ..
[03:35] <tsoliman> as far as tinsel is concerned .. the screen is 320x200
[03:36] <tsoliman> it's some kind of off-by-one error .. the X is 1 less than it should be in every loop
[03:37] --> jamm joined #scummvm.
[03:42] <snover> every loop of what?
[03:44] <tsoliman> the engine event loop I guess?
[03:45] <tsoliman> like it reads a keyboard input (e.g. KEYCODE_DOWN) - then adjusts the cursor
[03:46] <tsoliman> up and down are supposed to adjust Y .. but they warp the cursor .. I am trying to figure out why X is decremented by 1 every loop that Y is adjusted
[03:47] <tsoliman> sorry - I should back up .. I am looking at the X and Y of the _cursor_ :)
[03:51] <-- dreammaster left irc:
[03:55] <snover> when does the value become wrong?
[03:56] <tsoliman> that's what I am trying to figure out
[03:56] <tsoliman> I keep following it
[03:58] <tsoliman> I assumed you meant "what part of the code" .. if you meant "what conditions" then it is only when fullscreen + AR correction + new gfxmgr code
[03:58] <snover> only fullscreen or only when the window is scaled to a non-integral value?
[03:59] <tsoliman> that's a good point
[04:00] <tsoliman> let me see what happens with openGL so I can have a resizable window
[04:00] <tsoliman> snover you called it :)
[04:00] <tsoliman> both X and Y are fubared when using openGL an slightly resizing
[04:01] <snover> you are still using sdl1?
[04:01] <tsoliman> no sdl2
[04:01] <snover> the window is always resizable in sdl2
[04:01] <tsoliman> Oo
[04:01] <tsoliman> I wasn't paying attention when that got merged I guess :(
[04:03] <tsoliman> so this is a rounding problem then?
[04:07] <tsoliman> wow this is happening in SCI as well
[04:08] <tsoliman> this is definitely not tinsel-specific .. it is the new scaling code (I think) because it doesn't happen in the revision before they were merged
[04:08] <snover> https://gist.github.com/csnover/19022b5b9152fb253e7b00434a19a89d apply this and let me know how it is
[04:10] <snover> tsoliman: ^
[04:10] <tsoliman> trying now
[04:12] <snover> compile faster! ;)
[04:13] --> Mataniko joined #scummvm.
[04:16] <tsoliman> snover: that fixed it
[04:16] <tsoliman> the patch didn't apply cleanly (gimme a break)
[04:16] <tsoliman> I had to manually patch it
[04:16] <-- jamm left irc: Read error: Connection reset by peer
[04:16] <snover> heh. sorry. i cut and pasted out of git diff so who knows what i did
[04:16] <tsoliman> it is def. not off of scummvm/scummvm/master
[04:16] <snover> oh, it converted the tabs into spaces for me, thats what happened
[04:17] <snover> since i have git tab size set to 4
[04:17] <tsoliman> I did the "tabs till you indent" and then "spaces to push the wrap"
[04:17] <tsoliman> (same number of tabs as the original lines .. and then add spaces to taste)
[04:17] <tsoliman> which is what I was told to do by LordHoto in 2010ish
[04:18] <snover> a command line top tip, if you have some thing that formats for you and you dont want it to do that because you want raw output, pipe to cat.
[04:18] <snover> would you like me to commit this for you?
[04:19] <snover> (pipe to cat is especially useful for things which truncate, like ps)
[04:21] <snover> i dont rightly know why my brain failed to process this rounding error for so long
[04:21] <snover> this is not the first time someone has talked to me about it, and now it is obvious, and before it was apparently not obvious
[04:22] <snover> brains, man.
[04:26] <tsoliman> nah I am working on a commit right now
[04:26] <tsoliman> snover https://github.com/tsoliman/scummvm/commit/9ac0abd8c1231e0819cdf588716583c749cc03c8
[04:27] <tsoliman> how does that look?
[04:38] <snover> fine, the whitespace changes arent really& well, the next time dumb xcode gets ahold of that line it will end up with tabs again
[04:39] <tsoliman> I can revert the whitespace changes .. I was applying the patch manually and that's how they ended up there
[04:40] <tsoliman> (the diff seemed to be all spaces)
[04:40] <snover> it was, due to the aforementioned output formatting which i didnt think long enough to circumvent
[04:44] --> GitHub115 joined #scummvm.
[04:44] <GitHub115> [scummvm] tsoliman pushed 1 new commit to master: https://git.io/vNZDb
[04:44] <GitHub115> scummvm/master f285e38 Tarek Soliman: GRAPHICS: Fix rounding error when using non-integral scaling...
[04:44] GitHub115 (GitHub115@gateway/service/github.com/x-rehgvdirhhgxnnzo) left #scummvm.
[04:44] <tsoliman> ok I left the whitespaces in
[04:44] <tsoliman> let them be mangled later
[04:48] <snover> the fact of the matter is that all of this stuff could be automated away by clang-format too
[04:53] --> Strangerke_ joined #scummvm.
[04:55] <-- Strangerke left irc: Ping timeout: 256 seconds
[04:55] Nick change: Strangerke_ -> Strangerke
[05:27] --> jamm joined #scummvm.
[05:32] --> morpheous joined #scummvm.
[05:32] <-- jamm left irc: Read error: Connection reset by peer
[05:33] morpheous (morpheous@ool-68f67932.dyn.optonline.net) left #scummvm.
[05:35] --> morpheous joined #scummvm.
[05:44] --> jamm joined #scummvm.
[05:50] <-- jamm left irc: Read error: Connection reset by peer
[06:25] --> jamm joined #scummvm.
[06:28] <-- jamm left irc: Read error: Connection reset by peer
[07:03] --> jamm joined #scummvm.
[07:08] <-- jamm left irc: Read error: Connection reset by peer
[07:20] --> Strangerke_ joined #scummvm.
[07:22] <-- Strangerke left irc: Ping timeout: 256 seconds
[07:22] Nick change: Strangerke_ -> Strangerke
[07:49] --> waltervn joined #scummvm.
[07:49] #scummvm: mode change '+o waltervn' by ChanServ!ChanServ@services.
[08:07] --> jamm joined #scummvm.
[08:09] --> jammm joined #scummvm.
[08:12] <-- jamm left irc: Ping timeout: 264 seconds
[08:13] <-- jammm left irc: Ping timeout: 264 seconds
[08:20] --> jamm joined #scummvm.
[08:21] --> Begasus joined #scummvm.
[08:25] <-- jamm left irc: Read error: Connection reset by peer
[08:36] --> jamm joined #scummvm.
[08:42] <-- jamm left irc: Read error: Connection reset by peer
[09:07] --> Begas_VBox joined #scummvm.
[09:17] --> jamm joined #scummvm.
[09:18] <-- jamm left irc: Read error: Connection reset by peer
[09:18] --> jamm joined #scummvm.
[09:23] <-- jamm left irc: Ping timeout: 276 seconds
[09:43] --> jamm joined #scummvm.
[09:44] --> _sev joined #scummvm.
[09:44] <-- _sev left irc: Changing host
[09:44] --> _sev joined #scummvm.
[09:44] #scummvm: mode change '+o _sev' by ChanServ!ChanServ@services.
[09:48] <-- LittleToonCat left irc: Remote host closed the connection
[09:53] <-- jamm left irc: Read error: Connection reset by peer
[10:00] --> ajax16384 joined #scummvm.
[10:00] #scummvm: mode change '+o ajax16384' by ChanServ!ChanServ@services.
[10:05] <-- Drenn left irc: Ping timeout: 260 seconds
[10:14] <-- _sev left irc: Quit: This computer has gone to sleep
[10:16] --> _sev joined #scummvm.
[10:16] #scummvm: mode change '+o _sev' by ChanServ!ChanServ@services.
[10:44] --> Mia joined #scummvm.
[11:00] --> ignalina joined #scummvm.
[11:28] <-- Begas_VBox left irc: Quit: Vision[0.10.2]: i've been blurred!
[11:41] <-- Lightkey left irc: Ping timeout: 240 seconds
[11:44] <-- waltervn left irc: Quit: Leaving
[11:54] --> Lightkey joined #scummvm.
[12:06] <-- _sev left irc: Quit: This computer has gone to sleep
[12:14] --> _sev joined #scummvm.
[12:14] #scummvm: mode change '+o _sev' by ChanServ!ChanServ@services.
[12:22] <-- Begasus left irc: Ping timeout: 256 seconds
[12:25] <-- Cheeseness left irc: Read error: No route to host
[12:27] --> Cheeseness joined #scummvm.
[12:29] --> Begasus joined #scummvm.
[12:51] --> Begas_VBox joined #scummvm.
[13:13] <-- Begasus left irc: Ping timeout: 256 seconds
[13:25] --> Begasus joined #scummvm.
[13:36] --> jamm joined #scummvm.
[14:05] --> Strangerke_ joined #scummvm.
[14:07] <-- ajax16384 left irc: Read error: Connection reset by peer
[14:08] <-- Strangerke left irc: Ping timeout: 256 seconds
[14:08] Nick change: Strangerke_ -> Strangerke
[14:09] <-- Begasus left irc: Ping timeout: 256 seconds
[14:18] --> ny00123 joined #scummvm.
[14:19] <-- jamm left irc: Read error: Connection reset by peer
[14:21] --> Begasus joined #scummvm.
[14:25] Nick change: Storm-AFK -> Stormkeeper
[15:16] --> Littleboy joined #scummvm.
[15:16] #scummvm: mode change '+o Littleboy' by ChanServ!ChanServ@services.
[15:32] --> Farmboy0 joined #scummvm.
[15:32] <-- Farmboy0 left irc: Changing host
[15:32] --> Farmboy0 joined #scummvm.
[15:49] --> dreammaster joined #scummvm.
[15:49] #scummvm: mode change '+o dreammaster' by ChanServ!ChanServ@services.
[15:50] --> GitHub151 joined #scummvm.
[15:50] <GitHub151> [scummvm] dreammaster closed pull request #1108: TITANIC: Readme additions (master...TITANIC_readmeAdditions) https://git.io/vNTKK
[15:50] GitHub151 (GitHub151@gateway/service/github.com/x-cjbusimbvcpbgdyf) left #scummvm.
[15:50] --> GitHub77 joined #scummvm.
[15:50] <GitHub77> [scummvm] dreammaster pushed 3 new commits to master: https://git.io/vNn3Z
[15:50] <GitHub77> scummvm/master 95cf765 David Fioramonti: README: Add TITANIC DE saved game notes
[15:50] <GitHub77> scummvm/master 0c1aaf8 David Fioramonti: README: Add TITANIC function key controls
[15:50] <GitHub77> scummvm/master bc62369 Paul Gilbert: Merge pull request #1108 from dafioram/TITANIC_readmeAdditions...
[15:50] GitHub77 (GitHub77@gateway/service/github.com/x-nauqulseiaafbdbe) left #scummvm.
[15:52] --> GitHub177 joined #scummvm.
[15:52] <GitHub177> [scummvm] dreammaster pushed 1 new commit to master: https://git.io/vNn3l
[15:52] <GitHub177> scummvm/master 07f2b34 Paul Gilbert: XEEN: Fix re-encryption of save archive indexes
[15:52] GitHub177 (GitHub177@gateway/service/github.com/x-nodgyggfqsaacyji) left #scummvm.
[16:00] --> waltervn joined #scummvm.
[16:00] #scummvm: mode change '+o waltervn' by ChanServ!ChanServ@services.
[16:02] <-- waltervn left irc: Client Quit
[16:03] --> waltervn joined #scummvm.
[16:03] #scummvm: mode change '+o waltervn' by ChanServ!ChanServ@services.
[16:04] <-- Mia left irc: Read error: Connection reset by peer
[16:21] --> GitHub83 joined #scummvm.
[16:21] <GitHub83> [scummvm] bgK opened pull request #1111: SDL: Scale the joystick mouse speed with the vertical window size (master...gamepad-scale-mouse-speed-with-resolution) https://git.io/vNnG3
[16:21] GitHub83 (GitHub83@gateway/service/github.com/x-orihazcxatqvidsx) left #scummvm.
[16:22] --> GitHub137 joined #scummvm.
[16:22] <GitHub137> [scummvm] bgK pushed 4 new commits to master: https://git.io/vNnGl
[16:22] <GitHub137> scummvm/master 2c8afb2 Bastien Bouclet: COMMON: Add a reset method to DisposablePtr
[16:22] <GitHub137> scummvm/master 8fe7d52 Bastien Bouclet: VKEYBD: Fallback to SearchMan when loading keyboard packs
[16:22] <GitHub137> scummvm/master 3b8ffa0 Bastien Bouclet: BACKENDS: Remove vkeybdpath override from some ports...
[16:22] GitHub137 (GitHub137@gateway/service/github.com/x-tkfrrihmwjtjnbqd) left #scummvm.
[16:22] --> GitHub68 joined #scummvm.
[16:22] <GitHub68> [scummvm] bgK closed pull request #1097: VKEYBD: Fallback to SearchMan when loading keyboard packs (master...vkeybd-data-path) https://git.io/vbbkF
[16:22] GitHub68 (GitHub68@gateway/service/github.com/x-okiyaybnvkytpgtb) left #scummvm.
[16:23] --> GitHub193 joined #scummvm.
[16:23] <GitHub193> [scummvm] criezy pushed 1 new commit to master: https://git.io/vNnG4
[16:23] <GitHub193> scummvm/master d52bfbb Thierry Crozat: I18N: Update translations templates
[16:23] GitHub193 (GitHub193@gateway/service/github.com/x-lyenzfdupdpglkhf) left #scummvm.
[16:38] Nick change: Stormkeeper -> Storm-AFK
[16:39] <Lightkey> bgK: schnappszahl!
[17:33] <-- dreammaster left irc:
[18:46] --> LittleToonCat joined #scummvm.
[19:34] <-- thesquib left irc: Quit: ZNC - http://znc.in
[19:37] --> dreammaster joined #scummvm.
[19:37] #scummvm: mode change '+o dreammaster' by ChanServ!ChanServ@services.
[19:40] --> thesquib joined #scummvm.
[20:01] --> Joefish joined #scummvm.
[20:01] #scummvm: mode change '+v Joefish' by ChanServ!ChanServ@services.
[20:35] <rsn8887> How is this valid code : if (ConfMan.get("gfx_mode", _domain) != gm->name)
[20:35] <rsn8887> those are c strings
[20:36] <rsn8887> options.cpp line 459
[20:40] <dreammaster> Well, ConfMan.get returns a string doesn't it, and Common::String has an explicit variation for comparing against a passed const char *
[20:41] <dreammaster> I mean, ConfMan.get returns a Common::String
[20:43] --> Drenn joined #scummvm.
[20:44] <-- Begas_VBox left irc: Quit: Vision[0.10.2]: i've been blurred!
[20:45] <-- Begasus left irc: Quit: Ex-Chat
[20:47] <-- Joefish left irc: Ping timeout: 255 seconds
[20:47] --> Joefish joined #scummvm.
[20:47] #scummvm: mode change '+v Joefish' by ChanServ!ChanServ@services.
[20:53] <-- ignalina left irc: Ping timeout: 240 seconds
[21:16] <rsn8887> Yes thanks I was mistaken in thinking ConfMan.get would return a cstring pointer. all fine :)
[21:19] <dreammaster> NP. Always better to be accidentally wrong than to potentially leave a nasty gotcha in the core code
[21:21] --> GitHub7 joined #scummvm.
[21:21] <GitHub7> [scummvm] dreammaster pushed 1 new commit to master: https://git.io/vNnac
[21:21] <GitHub7> scummvm/master 17d68b8 Paul Gilbert: XEEN: Centralize logic for finding map in _mazeData array
[21:21] GitHub7 (GitHub7@gateway/service/github.com/x-bfdfktyrlxxhpbou) left #scummvm.
[21:22] --> GitHub102 joined #scummvm.
[21:22] <GitHub102> [scummvm] rsn8887 pushed 1 new commit to master: https://git.io/vNnaE
[21:22] <GitHub102> scummvm/master e6add01 rsn8887: GUI: never enable checkbox if GUI_ONLY_FULLSCREEN is set
[21:22] GitHub102 (GitHub102@gateway/service/github.com/x-nlffrjuuxydghksy) left #scummvm.
[21:22] --> GitHub26 joined #scummvm.
[21:22] <GitHub26> [scummvm] criezy pushed 1 new commit to master: https://git.io/vNnag
[21:22] <GitHub26> scummvm/master 6a66fe9 Thierry Crozat: I18N: Update translations templates
[21:22] GitHub26 (GitHub26@gateway/service/github.com/x-wjabbtstlvafjdry) left #scummvm.
[21:23] <-- Farmboy0 left irc: Read error: Connection reset by peer
[21:26] --> Farmboy0 joined #scummvm.
[22:30] --> GitHub126 joined #scummvm.
[22:30] <GitHub126> [scummvm] dreammaster pushed 1 new commit to master: https://git.io/vNnom
[22:30] <GitHub126> scummvm/master 5eb0388 Paul Gilbert: XEEN: Saving fixes for party and roster
[22:30] GitHub126 (GitHub126@gateway/service/github.com/x-oboyxgmzmliyfqet) left #scummvm.
[22:39] <-- Farmboy0 left irc: Remote host closed the connection
[22:47] <-- Dark-Star left irc: Ping timeout: 252 seconds
[22:49] --> Dark-Star joined #scummvm.
[23:14] <-- ny00123 left irc: Quit: Leaving
[23:14] <-- _sev left irc: Quit: This computer has gone to sleep
[23:16] --> _sev joined #scummvm.
[23:16] #scummvm: mode change '+o _sev' by ChanServ!ChanServ@services.
[23:33] <-- waltervn left irc: Quit: Leaving
[23:34] <-- _sev left irc: Quit: This computer has gone to sleep
[23:42] <-- girafe2 left irc: Read error: Connection reset by peer
[00:00] --- Sun Jan 14 2018