[00:01] dreammaster (~dreammast@c-73-149-116-247.hsd1.vt.comcast.net) joined #scummvm. [00:01] #scummvm: mode change '+o dreammaster' by ChanServ!ChanServ@services. [00:08] TAS_2012v (~2012@c-63fb71d5.024-3-67626724.cust.bredbandsbolaget.se) left irc: Ping timeout: 260 seconds [00:21] m_kiewitz, hopefully you read the log: using compressed KQ6 resource.aud crashes in 1.9.0 in kPortrait too [00:21] so, not a new problem, but an old one. [00:37] TAS_2012v (~2012@c-63fb71d5.024-3-67626724.cust.bredbandsbolaget.se) joined #scummvm. [00:47] Joefish (~ident@p200300C6F3C8CD004DE850C234FEED88.dip0.t-ipconnect.de) left irc: Ping timeout: 260 seconds [00:53] flesk_ (~quassel@2a03:b0c0:3:d0::4187:4001) left irc: Quit: No Ping reply in 210 seconds. [00:54] flesk_ (~quassel@2a03:b0c0:3:d0::4187:4001) joined #scummvm. [00:57] GitHub3 (~GitHub3@192.30.252.42) joined #scummvm. [00:57] [scummvm] dreammaster pushed 1 new commit to master: https://git.io/v9PDX [00:57] scummvm/master 53b0b82 Paul Gilbert: SHERLOCK: SS: Fix Italian fan detection entry language [00:57] GitHub3 (GitHub3@192.30.252.42) left #scummvm. [01:08] Dominus (~dominus@unaffiliated/dominus) left irc: Ping timeout: 260 seconds [01:08] Dominus (~dominus@unaffiliated/dominus) joined #scummvm. [01:11] SylvainTV (~SylvainTV@LFbn-1-8392-241.w81-254.abo.wanadoo.fr) left irc: Read error: Connection reset by peer [01:24] flesk_ (~quassel@2a03:b0c0:3:d0::4187:4001) left irc: Quit: No Ping reply in 180 seconds. [01:26] flesk_ (~quassel@46.101.104.92) joined #scummvm. [01:51] omer_mor_ (~Omer@46-117-132-33.bb.netvision.net.il) joined #scummvm. [01:54] omer_mor (~Omer@46-117-132-33.bb.netvision.net.il) left irc: Ping timeout: 268 seconds [01:56] dos1 (~dos1@neo900/coreteam/dos) left irc: Ping timeout: 246 seconds [02:04] dos1 (~dos1@neo900/coreteam/dos) joined #scummvm. [02:06] Mia (~Mia@unaffiliated/mia) left irc: Read error: Connection reset by peer [02:52] dos1 (~dos1@neo900/coreteam/dos) left irc: Ping timeout: 240 seconds [02:53] dos1 (~dos1@neo900/coreteam/dos) joined #scummvm. [02:59] flesk_ (~quassel@46.101.104.92) left irc: Quit: No Ping reply in 180 seconds. [02:59] dos1 (~dos1@neo900/coreteam/dos) left irc: Excess Flood [03:00] flesk_ (~quassel@2a03:b0c0:3:d0::4187:4001) joined #scummvm. [03:01] dos1 (~dos1@neo900/coreteam/dos) joined #scummvm. [03:05] omer_mor_ (~Omer@46-117-132-33.bb.netvision.net.il) left irc: Read error: Connection reset by peer [03:10] omer_mor (~Omer@46-117-132-33.bb.netvision.net.il) joined #scummvm. [03:16] snover: I found a minor bug in PR#937 [03:17] tsoliman: ok, whats happening? [03:17] macOS [03:17] 1. Start the scummvm launcher in windowed mode with 3x scaling. This creates a 960x720 launcher window. [03:17] 2. Start gk1-cd. This ignores scaling and uses 640x480 (normal) [03:17] 3. Fullscreen the game [03:17] 4. RTL. This switches back to windowed mode (normal) but at 640x480. In addition: the launcher looks like the 960x720 launcher scaled down to fit inside the 640x480 window. [03:19] im not reproducing that here. what sdl version are you using, and what mac os version? [03:19] (i tested both opengl and 2x) [03:20] dreammaster (~dreammast@c-73-149-116-247.hsd1.vt.comcast.net) left irc: [03:20] 3x [03:21] hm. things get& interesting& when the game is running in opengl and the launcher is not [03:22] libsdl2 @2.0.5_1+x11 [03:22] so 2.0.5 I guess [03:22] i wonder if macOS has its own problem with https://bugzilla.libsdl.org/show_bug.cgi?id=3637 [03:22] macOS 10.12.4 using the intel card [03:22] s/with/like [03:22] where did you install that from? +x11 sounds ominous [03:23] macports [03:23] because I hate myself [03:26] Retina 15" MBP Mid-2015 FWIW - happened in both the intel and the discrete AMD card [03:28] hmm .. I should mention that this is with master with your PR branch merged in rather than your actual commit (which is "old") [03:32] I don't understand how keyboard key events have to do with this? [03:32] AH [03:32] "like" :) sorry .. long day [03:33] interestingly .. this doesn't happen if you swap steps 2 and 3 [03:33] here, when i set launcher to 2x, game to opengl, start game, fullscreen, rtl, the window goes crazy resizing itself over and over again until it finally settles into an incorrect size [03:34] oh .. I didn't realize you could opengl the game with a surface launcher [03:34] it is an override of the graphics mode on the graphics tab for the games options [03:35] if you set the launcher to 3x (instead of 2x) and no overrides in the game, you cannot repro? [03:37] sorry, give me a minute, [04:15] ill have to look tomorrow, sorry [04:20] no worries :) [05:28] Simei (500be92b@gateway/web/freenode/ip.80.11.233.43) joined #scummvm. [06:08] Strangerke (~Strangerk@cable-85.28.84.13.coditel.net) left irc: Ping timeout: 268 seconds [06:31] m_kiewitz (~m_kiewitz@x4d03c5d1.dyn.telefonica.de) joined #scummvm. [06:31] m_kiewitz (~m_kiewitz@x4d03c5d1.dyn.telefonica.de) left irc: Changing host [06:31] m_kiewitz (~m_kiewitz@scummvm/undead/m-kiewitz) joined #scummvm. [06:31] #scummvm: mode change '+o m_kiewitz' by ChanServ!ChanServ@services. [06:36] Harekiet (~harekiet@kittens.harekiet.com) left irc: Remote host closed the connection [07:07] LittleToonCat (~littlecat@47.54.148.237) left irc: Remote host closed the connection [07:19] Harekiet (~harekiet@kittens.harekiet.com) joined #scummvm. [07:43] TMM (~hp@fsf/member/pdpc.professional.tmm) left irc: Quit: Ex-Chat [07:55] _sev|work (~sev@scummvm/undead/sev) joined #scummvm. [07:55] #scummvm: mode change '+o _sev|work' by ChanServ!ChanServ@services. [08:34] _sev|work (~sev@scummvm/undead/sev) left irc: Ping timeout: 272 seconds [08:40] TMM (~hp@fsf/member/pdpc.professional.tmm) joined #scummvm. [08:40] #scummvm: mode change '+o TMM' by ChanServ!ChanServ@services. [08:59] Joefish (~ident@p200300C6F3C40600ECE4ED3FD7DAF253.dip0.t-ipconnect.de) joined #scummvm. [08:59] #scummvm: mode change '+v Joefish' by ChanServ!ChanServ@services. [09:00] waltervn (~waltervn@541B2DBA.cm-5-4a.dynamic.ziggo.nl) joined #scummvm. [09:00] #scummvm: mode change '+o waltervn' by ChanServ!ChanServ@services. [09:04] _sev|work (~sev@5.57.20.49) joined #scummvm. [09:04] _sev|work (~sev@5.57.20.49) left irc: Changing host [09:04] _sev|work (~sev@scummvm/undead/sev) joined #scummvm. [09:04] #scummvm: mode change '+o _sev|work' by ChanServ!ChanServ@services. [09:20] _sev|work (~sev@scummvm/undead/sev) left irc: Quit: This computer has gone to sleep [09:38] Simei (500be92b@gateway/web/freenode/ip.80.11.233.43) left irc: Ping timeout: 260 seconds [09:45] _sev|work (~sev@scummvm/undead/sev) joined #scummvm. [09:45] #scummvm: mode change '+o _sev|work' by ChanServ!ChanServ@services. [10:01] Mia (~Mia@unaffiliated/mia) joined #scummvm. [10:52] ajax16384 (~User@109.60.138.138) joined #scummvm. [10:52] #scummvm: mode change '+o ajax16384' by ChanServ!ChanServ@services. [10:56] Simei (c3539b35@gateway/web/freenode/ip.195.83.155.53) joined #scummvm. [11:31] _sev|work (~sev@scummvm/undead/sev) left irc: Quit: This computer has gone to sleep [11:33] _sev|work (~sev@5.57.20.49) joined #scummvm. [11:33] _sev|work (~sev@5.57.20.49) left irc: Changing host [11:33] _sev|work (~sev@scummvm/undead/sev) joined #scummvm. [11:33] #scummvm: mode change '+o _sev|work' by ChanServ!ChanServ@services. [12:08] Simei (c3539b35@gateway/web/freenode/ip.195.83.155.53) left irc: Ping timeout: 260 seconds [12:33] _sev|work (~sev@scummvm/undead/sev) left irc: Quit: This computer has gone to sleep [12:35] _sev|work (~sev@5.57.20.49) joined #scummvm. [12:35] _sev|work (~sev@5.57.20.49) left irc: Changing host [12:35] _sev|work (~sev@scummvm/undead/sev) joined #scummvm. [12:35] #scummvm: mode change '+o _sev|work' by ChanServ!ChanServ@services. [12:55] _sev|work (~sev@scummvm/undead/sev) left irc: Quit: This computer has gone to sleep [13:07] _sev (~sev@scummvm/undead/sev) joined #scummvm. [13:07] #scummvm: mode change '+o _sev' by ChanServ!ChanServ@services. [13:08] _sev_ (~sev@scummvm/undead/sev) left irc: Ping timeout: 240 seconds [13:33] _sev|work (~sev@scummvm/undead/sev) joined #scummvm. [13:33] #scummvm: mode change '+o _sev|work' by ChanServ!ChanServ@services. [13:57] _sev|work (~sev@scummvm/undead/sev) left irc: Quit: This computer has gone to sleep [14:00] _sev|work (~sev@scummvm/undead/sev) joined #scummvm. [14:00] #scummvm: mode change '+o _sev|work' by ChanServ!ChanServ@services. [14:06] Simei (c3539b35@gateway/web/freenode/ip.195.83.155.53) joined #scummvm. [14:13] Simei (c3539b35@gateway/web/freenode/ip.195.83.155.53) left irc: Ping timeout: 260 seconds [14:29] ST (~ScottT@203-227-181-180.cpe.skymesh.net.au) joined #scummvm. [14:29] #scummvm: mode change '+o ST' by ChanServ!ChanServ@services. [14:36] HaBe (~Heiko@p5B06C3F1.dip0.t-ipconnect.de) joined #scummvm. [14:40] Mia (~Mia@unaffiliated/mia) left irc: Read error: Connection reset by peer [14:46] Mia (~Mia@unaffiliated/mia) joined #scummvm. [14:48] Tomaz^W (~tompsson@84.216.7.40) joined #scummvm. [14:49] Simei (c3539b35@gateway/web/freenode/ip.195.83.155.53) joined #scummvm. [15:00] ScummBot_ (~ScummBot@vm2.scummvm.org) left irc: Ping timeout: 240 seconds [15:00] _sev|work (~sev@scummvm/undead/sev) left irc: Quit: This computer has gone to sleep [15:04] ScummBot (~ScummBot@vm2.scummvm.org) joined #scummvm. [15:05] ST (~ScottT@203-227-181-180.cpe.skymesh.net.au) left irc: Ping timeout: 252 seconds [15:07] Henke37 (~Henrik@81-227-16-59-no133.bredband.skanova.com) joined #scummvm. [15:08] Begasus (~begasus@ptr-4p6jpilmdcvc569z2g2.18120a2.ip6.access.telenet.be) joined #scummvm. [15:13] TMM (~hp@fsf/member/pdpc.professional.tmm) left irc: Quit: Ex-Chat [15:15] Hello, everyone, I have a problem concerning git. I think I've messed up the things a little in my fork. So I want to ask here. :/ [15:16] I have 2 branches : master and cmd [15:16] In my master there are 3 commits: [15:16] - commit 1 : add a new commande line in base/commandline.cpp [15:16] - commit 2 : a merge commit to upstream [15:16] - commit 3 : a commit to add files to detect a new type of game file [15:16] In my cmd there are 2 commits: [15:16] - commit 1 : add a new commande line in base/commandline.cpp [15:16] - commit 4 : fix errors in base/commandline.cpp [15:16] I created a PR from the cmd branch and it was closed and commits were merged by squashing the 2 commits into one. [15:17] Now I only want to keep the commit 3 in my own fork, abandon the rest and synchronise everything to upstream. [15:17] What I want to do is : [15:17] 1. delete cmd branch [15:17] 2. remove commit1 and commit2 in master [15:17] 3. rebase commit3 to the top and merge upstream [15:17] Is this the right way to do so? [15:18] Sorry for a question so long. :p Thanks a lot if anyone has time to read it. :) [15:22] here is one way to do that (assuming upstream remote is named `upstream`): `git checkout master; git branch -D cmd; git fetch upstream; git rebase -i upstream/master` and delete the lines corresponding to commits you no longer want [15:26] Thank you for your quick answer! Should I delete the commits I don't want before rebase them or it doesn't matter ? [15:26] Simei_ (c3539b35@gateway/web/freenode/ip.195.83.155.53) joined #scummvm. [15:27] Thank you for your answer so quick! :D [15:27] Should I delete the commits before rebase them ? [15:28] Because some of them have conflicts with current files in upstream [15:29] t0by (~t0by@host64-34-dynamic.15-87-r.retail.telecomitalia.it) joined #scummvm. [15:29] t0by (~t0by@host64-34-dynamic.15-87-r.retail.telecomitalia.it) left irc: Changing host [15:29] t0by (~t0by@unaffiliated/t0by) joined #scummvm. [15:29] #scummvm: mode change '+o t0by' by ChanServ!ChanServ@services. [15:30] Simei (c3539b35@gateway/web/freenode/ip.195.83.155.53) left irc: Ping timeout: 260 seconds [15:31] Simei_ (c3539b35@gateway/web/freenode/ip.195.83.155.53) left irc: Quit: Page closed [15:32] Simei (c3539b35@gateway/web/freenode/ip.195.83.155.53) joined #scummvm. [15:33] t0by__ (~t0by@unaffiliated/t0by) joined #scummvm. [15:33] #scummvm: mode change '+o t0by__' by ChanServ!ChanServ@services. [15:35] t0by (~t0by@unaffiliated/t0by) left irc: Ping timeout: 255 seconds [15:41] Begas_VBox (~Begasus@d54C3C8C2.access.telenet.be) joined #scummvm. [15:55] GitHub166 (~GitHub166@192.30.252.42) joined #scummvm. [15:55] [scummvm] csnover pushed 2 new commits to master: https://git.io/v91lM [15:55] scummvm/master dd13c3b Colin Snover: SCI: Fix support for ScummVM compressed audio volumes... [15:55] scummvm/master 67b72cc Colin Snover: SCI: Remove unused Robot code from SCI16 audio code [15:55] GitHub166 (GitHub166@192.30.252.42) left #scummvm. [15:55] t0by__ (~t0by@unaffiliated/t0by) left irc: Quit: t0by__ [15:55] m_kiewitz: all fixed! :-) [15:58] _sev|work (~sev@scummvm/undead/sev) joined #scummvm. [15:58] #scummvm: mode change '+o _sev|work' by ChanServ!ChanServ@services. [15:59] WooShell (~Markus@ipbcc071f5.dynamic.kabel-deutschland.de) joined #scummvm. [16:08] I've solved my problem! Thanks for the help. :) [16:08] t0by (~t0by@unaffiliated/t0by) joined #scummvm. [16:08] #scummvm: mode change '+o t0by' by ChanServ!ChanServ@services. [16:09] meow =^.^= [16:10] _sev|work (~sev@scummvm/undead/sev) left irc: Quit: This computer has gone to sleep [16:10] ny00123 (~ny00123@109.64.146.96) joined #scummvm. [16:15] Simei (c3539b35@gateway/web/freenode/ip.195.83.155.53) left irc: Ping timeout: 260 seconds [16:16] m_kiewitz: https://bugs.scummvm.org/ticket/9776#comment:5 have you seen this on other international releases (name of patches directory being something other than PATCHES)? [16:19] LittleToonCat (~littlecat@47.54.148.237) joined #scummvm. [16:35] snover: my localized Torin's Passage has no patches at all [16:37] im wondering if it is safe to add the "patch" directory, in the similar manner as the "patches" directory is added now [16:38] or if we need to start reading patchDir from resource.cfg [16:39] the latter isn't good, because that would require the user to install the game using the original installer [16:39] just add it [16:44] ajax16384 (~User@109.60.138.138) left irc: Quit: Leaving [16:54] ok, i will do that. [16:54] i thought the resource.cfg files could be read from the CD media since they exist there, but looking at them, it does seem they dont quite have all the expected information. [16:55] not on mine [16:56] oh wait, it's in a subdirectory lol [16:57] for my English Torin's Passage it's inside the same subdirectory [16:57] BUT the English one has a patches folder and it's not mentioned inside resource.cfg [16:57] >_< [16:57] lol [16:58] yeah. the installer does do some &stuff [16:59] i guess at some point we should change it to a blacklist [16:59] i think that's going to be easier [17:00] depending on the installer, the patchDir information is in INSTALL.INS or INSTALL.SCR [17:00] ¯\_(Ä)_/¯ [17:01] lol [17:01] yeah let us create our own ScummVM installer heh [17:01] echo patchDir= %1:%4;%2:\patches >>resource.cfg [17:01] sigh [17:08] GitHub111 (~GitHub111@192.30.252.42) joined #scummvm. [17:08] [scummvm] csnover pushed 2 new commits to master: https://git.io/v91XH [17:08] scummvm/master 200adb9 Colin Snover: SCI: Add example of KQ6 game with incorrect patches directory [17:08] scummvm/master 9e83977 Colin Snover: SCI: Add "patch" directory to search paths... [17:08] GitHub111 (GitHub111@192.30.252.42) left #scummvm. [17:08] sigh indeed! [17:08] GitHub14 (~GitHub14@192.30.252.42) joined #scummvm. [17:08] [scummvm] criezy pushed 1 new commit to master: https://git.io/v91Xd [17:08] scummvm/master 80e7eaa Thierry Crozat: I18N: Update translations templates [17:08] GitHub14 (GitHub14@192.30.252.42) left #scummvm. [17:22] Farmboy0 (~quassel@p4FD345FD.dip0.t-ipconnect.de) joined #scummvm. [17:22] Farmboy0 (~quassel@p4FD345FD.dip0.t-ipconnect.de) left irc: Changing host [17:22] Farmboy0 (~quassel@xoreos/farmboy0) joined #scummvm. [17:22] salty-horse (~salty-hor@bzq-79-181-137-174.red.bezeqint.net) joined #scummvm. [17:22] salty-horse (~salty-hor@bzq-79-181-137-174.red.bezeqint.net) left irc: Changing host [17:22] salty-horse (~salty-hor@unaffiliated/salty-horse) joined #scummvm. [17:22] #scummvm: mode change '+o salty-horse' by ChanServ!ChanServ@services. [17:34] frankyboy_ (~franky@ppp109-252-72-14.pppoe.spdop.ru) joined #scummvm. [17:41] frankyboy_ (~franky@ppp109-252-72-14.pppoe.spdop.ru) left irc: Read error: Connection reset by peer [17:41] Begas_VBox (~Begasus@d54C3C8C2.access.telenet.be) left irc: Read error: Connection reset by peer [17:41] frankyboy_ (~franky@ppp109-252-72-14.pppoe.spdop.ru) joined #scummvm. [17:43] Begasus (~begasus@ptr-4p6jpilmdcvc569z2g2.18120a2.ip6.access.telenet.be) left irc: Ping timeout: 255 seconds [17:48] frankyboy_ (~franky@ppp109-252-72-14.pppoe.spdop.ru) left irc: Quit: ... [17:49] Farmboy0 (~quassel@xoreos/farmboy0) left irc: Read error: No route to host [17:50] arf [17:50] Terrible timing on my part. [18:00] ajax16384 (~User@109.60.130.33) joined #scummvm. [18:00] #scummvm: mode change '+o ajax16384' by ChanServ!ChanServ@services. [18:06] SylvainTV (~SylvainTV@LFbn-1-8392-241.w81-254.abo.wanadoo.fr) joined #scummvm. [18:06] #scummvm: mode change '+o SylvainTV' by ChanServ!ChanServ@services. [18:16] Farmboy0 (~quassel@xoreos/farmboy0) joined #scummvm. [18:30] girafe (~girafe@LFbn-1-11729-221.w2-7.abo.wanadoo.fr) joined #scummvm. [19:02] snover: very nice catch on that compression tool; seems it was right :-) [19:03] TMM (~hp@fsf/member/pdpc.professional.tmm) joined #scummvm. [19:03] #scummvm: mode change '+o TMM' by ChanServ!ChanServ@services. [19:07] Strangerke (~Strangerk@cable-85.28.84.13.coditel.net) joined #scummvm. [19:08] TMM (~hp@fsf/member/pdpc.professional.tmm) left irc: Quit: Ex-Chat [19:10] frankyboy_ (~franky@ppp109-252-72-14.pppoe.spdop.ru) joined #scummvm. [19:12] TMM (~hp@fsf/member/pdpc.professional.tmm) joined #scummvm. [19:12] #scummvm: mode change '+o TMM' by ChanServ!ChanServ@services. [19:14] GitHub95 (~GitHub95@192.30.252.42) joined #scummvm. [19:14] [scummvm-sites] criezy pushed 2 new commits to web-planet: https://git.io/v9MeN [19:14] scummvm-sites/web-planet 1429671 Thierry Crozat: PLANET: Add 2017 GSoC blog for Simei [19:14] scummvm-sites/web-planet 7d581df Thierry Crozat: PLANET: Add avatar for criezy [19:14] GitHub95 (GitHub95@192.30.252.42) left #scummvm. [19:22] Begasus (~begasus@ptr-4p6jpinwn06v7ibard9.18120a2.ip6.access.telenet.be) joined #scummvm. [19:29] Begas_VBox (~Begasus@d54c3c8c2.access.telenet.be) joined #scummvm. [19:47] snover: so the compression code didn't destroy the rave data at all? [19:47] wjp: i would have flailed for probably quite a while longer if it hadnt been for the single comment with the error in KQ6 [19:48] m_kiewitz: as far as i can tell, the compression tool loses the rave data [19:48] I'm actually surprised, but right I think the sync data is actually in resource.aud and rave data is just appended after it without being inside the sync data [19:48] oh? it does? [19:48] will try to fix that then [19:48] as i said - we had no idea what sierra did back then [19:48] there arent offsets in the relocation table for the rave resources (or they are wrong) [19:48] i think i wrote the compression code in 2010 or so [19:49] ah no, the rave data has no explicit offsets [19:49] it was hacked in by Sierra or whoever did the hires portraits stuff [19:49] I think rave data is just added to sync data (without sync size being increased) [19:50] so it's in a black hole so to speak [19:50] it took quite a bit until we even figured out where that lip sync data was [19:50] and then it took us possibly 2 or 3 years to full reverse the algo to use it [19:51] hm. well, the rave resources are added to the resource manager using offset `offset + syncSize`, in resource_audio.cpp:447 [19:51] (effectively we used regular sync data for hires lip sync until we finally figured out how to use the rave data) [19:51] yes [19:51] offset of sync + syncsize [19:52] so the rave data is behind the sync data [19:52] in a place, where there shouldn't be any data [19:52] (well where the next audio sample would normally start) [19:53] and i think size is calculated by looking up the sample offset behind that and then subtracting the calculated rave offset from it - in case I remember correctly [19:53] as i said - it's basically hidden data [19:56] or maybe the rave size was inside another field, idk for sure anymore [19:56] im pretty sure that sierra definitely didn't enlarge the resource audio header [19:57] Who needs self describing data formats [19:58] ok, in that case, let me see if i can just do some adjusting after the resource offset is remapped and get the rave data out [19:58] i'm not sure if my compression code didn't throw the rave data out of the file [19:58] anyway, what we could do however at some point - i think some dialog in kq6 doesn't have rave data [19:59] and some dialog doesn't have sync data [19:59] or maybe it was just that sync data is missing, not sure [19:59] anyway, we could actually recreate the sync data by using the rave data [19:59] wizardry! [19:59] that was my idea for quite some time, but it is actually possible [19:59] rave data contains quite a few more animations [19:59] and is more accurate [20:00] i know that at least one dialog inside the book store has no lip sync [20:00] and afaik the scripts then do a blabber mouth [20:00] random mouth movements [20:00] looks hilarious [20:01] twitch.tv/gogcom everybody LoL now [20:01] in sci32 they added stuff to the audio code so they could get away using random mouth movements cued to the audio volume of the sample being played back [20:01] blabbermouth? Is that random movement? [20:01] ls [20:02] derp [20:02] nvm, already explained [20:02] frankyboy_ (~franky@ppp109-252-72-14.pppoe.spdop.ru) left irc: Quit: ... [20:02] TMN: yes, basically random mouth movements, and looks absolutely distracting [20:02] frankyboy_ (~franky@ppp109-252-72-14.pppoe.spdop.ru) joined #scummvm. [20:02] especially when most dialog has proper lip sync [20:02] snover: wow [20:03] sierra was the expert on lip sync back then [20:03] hm.. smells like netsplit in here [20:03] :) [20:03] and some games even nowadays don't get it right [20:03] they had proprietary software to make lip syncing quite easy [20:04] but it was still time consuming [20:04] i think that software tried to do it automatically, but humans still needed to jump in and fix bad stuff [20:04] thimbleweedpark used a program called 'rhubarb lipsync' [20:04] still amazing [20:04] it's kind of interesting [20:04] wasnt the new mass effect full of lipsync problems? [20:05] *full of problems [20:05] heh :) [20:05] wjp: oops, i am supposed to accept complements. thanks for the complement :) [20:06] https://www.youtube.com/watch?v=QDjci1ODoBs [20:06] in DOSBox.. meh [20:07] snover: one's or two's complement? [20:07] booooo. [20:07] :) [20:10] so hey [20:10] I've been building a media pc for my friend [20:11] getting things set up has been...I dunno, fairly straightforward [20:11] I dumped a bunch of her scumm/etc games she had onto the machine for scummvm and it picked them up fine [20:12] but she's got a lot of stuff; does scummvm just have a scan/autoadd feature and I missed it? [20:12] hitting add like 20+times can get tedious [20:12] --massadd [20:12] nice, thank you [20:13] ^^ the --massadd effect :P [20:15] m_kiewitz: so, it looks like the rave data is probably alright in the compressed volume after all. [20:15] it is? [20:16] well you should easily see it with a hex editor [20:16] it's ASCII chars [20:16] i didn't compress by kq6, so i can't check easily [20:16] seems that way. after bypassing the offset validation for the non-existing offsets, portraits have lipsync [20:17] ahh nice [20:17] or at least, the portaits in the first town do. i cant speak for the rest of the game. :) [20:17] i'm surprised that this data survived [20:18] well when some survived, then I guess all survived [20:18] i guess i went from offset to offset and kept sync data (without using size) then [20:19] the compression tool does emit Warning: possibly raw lipsync data found at offset  [20:25] ah [20:25] ah, so we knew about it already [20:25] well we at least knew that there was some extra data [20:25] omer_mor_ (~Omer@46-117-132-33.bb.netvision.net.il) joined #scummvm. [20:28] omer_mor (~Omer@46-117-132-33.bb.netvision.net.il) left irc: Ping timeout: 260 seconds [20:30] Begas_VBox (~Begasus@d54c3c8c2.access.telenet.be) left irc: Quit: Vision[0.9.8]: i've been blurred! [20:36] GitHub49 (~GitHub49@192.30.252.34) joined #scummvm. [20:36] [scummvm] csnover pushed 1 new commit to master: https://git.io/v9MYz [20:36] scummvm/master ea6eebc Colin Snover: SCI: Fix reading of Rave data from compressed KQ6 audio volumes... [20:36] GitHub49 (GitHub49@192.30.252.34) left #scummvm. [20:36] \o/ [20:37] Begas_VBox (~Begasus@d54C3C8C2.access.telenet.be) joined #scummvm. [20:40] i wonder how nobody encountered this before (at least i can find no bugs in the bug tracker about it) since it raised an error in 1.9.0 too [20:41] probably no one compressed the kq6 audio [20:47] yeah, i wasnt even sure this tool still existed at first. it isnt explicitly described anywhere except the forum and a couple tickets in the bug tracker [20:47] there is a Tools page on the wiki, but compress_sci is conspicuously absent [20:51] Begasus (~begasus@ptr-4p6jpinwn06v7ibard9.18120a2.ip6.access.telenet.be) left irc: Quit: Ex-Chat [20:51] Begas_VBox (~Begasus@d54C3C8C2.access.telenet.be) left irc: Quit: Vision[0.9.8]: i've been blurred! [20:55] hm. this patch that was added for supporting kq5 audio is kind of broken, all the filenames given to the tool have to be lowercase matching "resource.*", so audio001.002 has to be renamed to something like resource.aud [20:58] wjp: can this ADeadTrousers person really not upload files on trac or do they just keep missing the attach button? [20:58] https://bugs.scummvm.org/ticket/9772#comment:5 [21:01] kq5 audio is afaik compressed in a different manner [21:02] who added that? [21:02] https://github.com/scummvm/scummvm-tools/pull/2 [21:02] K4T (K4T@193.0.192.199) joined #scummvm. [21:04] I was wondering about that too. I don't think I've heard about upload problems before from anyone [21:05] m_kiewitz: it *does* create a working compressed audio volume, its just& very confusing to use [21:06] can't we select to types of files? [21:07] otherwise maybe there should be 2 types of SCI - SCI (KQ5, Jones) and SCI (everything else) [21:10] i dont know; this thing is pretty low on my list of priorities :) [21:12] waltervn (~waltervn@541B2DBA.cm-5-4a.dynamic.ziggo.nl) left irc: Read error: Connection reset by peer [21:24] Henke37 (~Henrik@81-227-16-59-no133.bredband.skanova.com) left irc: Quit: ERR_SHUTDOWN [21:30] omer_mor (~Omer@46-117-132-33.bb.netvision.net.il) joined #scummvm. [21:32] omer_mor_ (~Omer@46-117-132-33.bb.netvision.net.il) left irc: Ping timeout: 240 seconds [21:47] wjp: could you turn on [wiki]ignore_missing_pages and bump [mimeviewer]max_preview_size to 1MB? [21:47] &in trac* [21:48] people keep uploading uncompressed bitmaps that i dont want to have to download, and i keep typing class names that get turned into bad wiki links :) [21:55] t0by (~t0by@unaffiliated/t0by) left irc: Quit: t0by [21:56] t0by (~t0by@host151-252-dynamic.5-87-r.retail.telecomitalia.it) joined #scummvm. [21:56] t0by (~t0by@host151-252-dynamic.5-87-r.retail.telecomitalia.it) left irc: Changing host [21:56] t0by (~t0by@unaffiliated/t0by) joined #scummvm. [21:56] #scummvm: mode change '+o t0by' by ChanServ!ChanServ@services. [22:02] frankyboy_ (~franky@ppp109-252-72-14.pppoe.spdop.ru) left irc: Quit: ... [22:07] WooShell (~Markus@ipbcc071f5.dynamic.kabel-deutschland.de) left irc: Quit: If you understand or if you don't, if you believe or if you doubt - There's a universal justice, and the eyes of truth are always watching you. [22:12] snover: yup, I hate those uncompressed bitmaps too. But I guess we are at fault, because afaik scummVM saves screenshots that way [22:12] isn't there RLE compression for bitmaps? [22:13] ajax16384 (~User@109.60.130.33) left irc: Read error: Connection reset by peer [22:13] which is still bad, but may improve things a bit [22:14] We have libpng already as a optional dep don't we.? [22:14] ny00123 (~ny00123@109.64.146.96) left irc: Quit: Leaving [22:14] ah, we do? [22:14] but well optional [22:15] is there still a GIF patent? [22:15] or has that expired? [22:15] we could default to gif in that case for 256 color games [22:16] Seems weird to do that when there is png for all? [22:17] well when we have png as optional, then it makes sense to have a short gif compression method [22:18] HaBe (~Heiko@p5B06C3F1.dip0.t-ipconnect.de) left irc: Ping timeout: 255 seconds [22:18] I'm on my phone so can't look at things now [22:19] my own command line tool for compressing bitmap files as gif is 1000 lines only [22:19] gif compression itself seems to be 270 lines [22:20] Maybe look first at which build s don't have png support before going down this gif path [22:21] sure, but still i think a few additional lines of code and gif support for screenshots isn't so bad [22:22] i think i never managed to get libpng to work on my system [22:22] m_kiewitz: all relevant patents expired quite a while ago [22:22] that's nice [22:22] hum, 2004 according to wikipedia [22:22] MP3 seems to expire soon too (or has expired) [22:22] expired a few weeks back I think [22:22] i don't know the details, i was just happy that this one is gone too [22:23] software patents shouldn't exist at all [22:24] ah, found the tweet I was thinking of, https://twitter.com/icculus/status/853772981344063489 [22:25] so MP3 expired ~3.5 weeks ago (if that tweet is correct) [22:25] snover: when you check, please also check daily builds and if png is used for screenshots when it's included [22:26] OK I'll let you know when I do [22:26] maybe we do not use it for screenshots at all, or maybe it's not built into the daily builds?! [22:33] geep (~JoeBelow@xplr-104-249-224-181.xplornet.com) joined #scummvm. [22:37] exmensa (~exmensa@66.43.202.238) left irc: Read error: Connection reset by peer [22:44] Farmboy0 (~quassel@xoreos/farmboy0) left irc: Remote host closed the connection [22:46] HaBe (~Heiko@91.6.195.241) joined #scummvm. [22:48] borosky (~broosky@178.235.41.205) left irc: Ping timeout: 240 seconds [22:52] t0by (~t0by@unaffiliated/t0by) left irc: Quit: t0by [22:56] girafe (~girafe@LFbn-1-11729-221.w2-7.abo.wanadoo.fr) left irc: Quit: Leaving [22:57] software patents shouldn't ever be valid >_< [23:01] borosky (~broosky@095160154186.dynamic-ww-11.vectranet.pl) joined #scummvm. [23:12] m_kiewitz: nothing uses libpng currently. there is a decoder wrapper for it but no encoder wrapper. screenshots are saved by SDL_SaveBMP in SDL backend, and by some hand-written BMP writer in OpenGL backend. Thumbnails are serialised in a custom format (relying on gzip on the entire save stream for compression) and explicitly only support 16bpp or 32bpp. [23:13] so gif here we go? :P [23:13] _sev (~sev@scummvm/undead/sev) left irc: Ping timeout: 260 seconds [23:15] K4T (K4T@193.0.192.199) left irc: Read error: Connection reset by peer [23:15] i would not personally jump to that conclusion. [23:16] well how many platforms are missing libpng? [23:25] _sev (~sev@a238130.upc-a.chello.nl) joined #scummvm. [23:25] _sev (~sev@a238130.upc-a.chello.nl) left irc: Changing host [23:25] _sev (~sev@scummvm/undead/sev) joined #scummvm. [23:25] #scummvm: mode change '+o _sev' by ChanServ!ChanServ@services. [23:34] ill have to do a little more digging, it is required by sword25 and wintermute engines, so any platform with those engines has it [23:34] brb [23:39] salty-horse (~salty-hor@unaffiliated/salty-horse) left irc: Quit: Leaving [23:40] m_kiewitz (~m_kiewitz@scummvm/undead/m-kiewitz) left irc: Quit: technology isn't intrinsically good or evil. It's how it's used. Like the Death Ray. [00:00] --- Thu May 11 2017