[00:26] timofonic2 (~timofonic@67.115.20.95.dynamic.jazztel.es) left irc: Ping timeout: 265 seconds [00:30] Littleboy (~littleboy@c-71-233-131-7.hsd1.ma.comcast.net) left irc: Quit: Être dans le vent, une ambition de feuille morte. [00:38] Strangerke (~Strangerk@cable-85.28.84.13.coditel.net) left irc: Ping timeout: 276 seconds [00:49] the good news is that at the moment ive broken all saves, including the new ones :) [00:53] timofonic2 (~timofonic@67.115.20.95.dynamic.jazztel.es) joined #scummvm. [01:20] sluicebox (~cbone@104-6-194-213.lightspeed.irvnca.sbcglobal.net) left irc: Remote host closed the connection [01:29] timofonic2 (~timofonic@67.115.20.95.dynamic.jazztel.es) left irc: Ping timeout: 255 seconds [01:38] ScHlAuChi (~schlauchi@p5DC4F3BC.dip0.t-ipconnect.de) joined #scummvm. [01:39] ScHlAuChi (schlauchi@p5DC4F3BC.dip0.t-ipconnect.de) left #scummvm. [01:45] Vampire0_ (~Vampire@jEdit/Vampire) joined #scummvm. [01:48] Vampire0 (~Vampire@jEdit/Vampire) left irc: Ping timeout: 244 seconds [02:07] Nick change: Vampire0_ -> Vampire0 [02:21] snover (~Adium@unaffiliated/snover) left irc: Quit: Leaving. [02:22] _dreammaster (~dreammast@c-73-167-118-204.hsd1.ma.comcast.net) joined #scummvm. [02:22] #scummvm: mode change '+o _dreammaster' by ChanServ!ChanServ@services. [02:24] dreammaster (~dreammast@c-73-167-118-204.hsd1.ma.comcast.net) left irc: Ping timeout: 240 seconds [02:33] Nick change: _dreammaster -> dreammaster [02:35] GitHub91 (~GitHub91@192.30.252.40) joined #scummvm. [02:35] [scummvm] dreammaster pushed 1 new commit to master: https://git.io/viWgl [02:35] scummvm/master 307cd0d Paul Gilbert: SHERLOCK: RT: Fix crash using invalid number keys in conversations [02:35] GitHub91 (GitHub91@192.30.252.40) left #scummvm. [02:46] dreammaster (~dreammast@c-73-167-118-204.hsd1.ma.comcast.net) left irc: [02:51] Henke37 (~Henrik@81-227-16-59-no133.bredband.skanova.com) left irc: Quit: ERR_SHUTDOWN [04:22] timofonic2 (~timofonic@67.115.20.95.dynamic.jazztel.es) joined #scummvm. [04:47] timofonic2 (~timofonic@67.115.20.95.dynamic.jazztel.es) left irc: Ping timeout: 260 seconds [05:38] waltervn (~waltervn@82-171-142-149.ip.telfort.nl) joined #scummvm. [05:38] #scummvm: mode change '+o waltervn' by ChanServ!ChanServ@services. [05:38] timofonic2 (~timofonic@194.224.153.207) joined #scummvm. [05:54] WinterGrascph (~WinterGra@winter.sch.bme.hu) joined #scummvm. [05:54] #scummvm: mode change '+v WinterGrascph' by ChanServ!ChanServ@services. [05:55] ajax16384 (~User@ip138.net138.n37.ru) joined #scummvm. [05:55] #scummvm: mode change '+o ajax16384' by ChanServ!ChanServ@services. [06:00] timofonic2 (~timofonic@194.224.153.207) left irc: Read error: Connection reset by peer [06:00] timofonic2 (~timofonic@194.224.153.207) joined #scummvm. [06:05] WinterGrascph (~WinterGra@winter.sch.bme.hu) left irc: Ping timeout: 265 seconds [06:40] WooShell (~Markus@ipbcc071f7.dynamic.kabel-deutschland.de) joined #scummvm. [06:43] good meowning =^.^= [07:01] -ChanServ:#scummvm- _sev set flags +AOort on blorente1 [07:12] timofonic2 (~timofonic@194.224.153.207) left irc: Read error: Connection reset by peer [07:31] m_kiewitz (~m_kiewitz@x4d03ead6.dyn.telefonica.de) joined #scummvm. [07:31] m_kiewitz (~m_kiewitz@x4d03ead6.dyn.telefonica.de) left irc: Changing host [07:31] m_kiewitz (~m_kiewitz@scummvm/undead/m-kiewitz) joined #scummvm. [07:31] #scummvm: mode change '+o m_kiewitz' by ChanServ!ChanServ@services. [07:38] Strangerke|work (5bb7582b@gateway/web/freenode/ip.91.183.88.43) joined #scummvm. [07:38] hi guys [07:39] hola [07:42] The refactoring/renaming of DM is killing me :) [07:45] don't worry, eden will do it even faster :) [07:51] Considering how much time I already spent on DM... Without a doubt :) [07:51] And it's not over [07:57] morning all [07:57] G'day waltervn [08:07] girafe (~girafe@LFbn-1-8015-136.w90-112.abo.wanadoo.fr) left irc: Read error: Connection reset by peer [08:09] WinterGrascph (~WinterGra@dhcp-1726.q.wlan.net.bme.hu) joined #scummvm. [08:09] #scummvm: mode change '+v WinterGrascph' by ChanServ!ChanServ@services. [08:09] criezy (~criezy@host86-175-211-233.range86-175.btcentralplus.com) joined #scummvm. [08:09] #scummvm: mode change '+o criezy' by ChanServ!ChanServ@services. [08:09] WinterGrascph (~WinterGra@dhcp-1726.q.wlan.net.bme.hu) left irc: Client Quit [08:14] GitHub117 (~GitHub117@192.30.252.42) joined #scummvm. [08:14] [scummvm] criezy pushed 2 new commits to master: https://git.io/viW7X [08:14] scummvm/master f00d8f7 Thierry Crozat: I18N: Update Hungarian translation [08:14] scummvm/master aa879ec Thierry Crozat: I18N: Regenerate translations data file [08:14] GitHub117 (GitHub117@192.30.252.42) left #scummvm. [08:17] wjp: just in case you didn't see/receive the email from our Hungarian translator, plese see http://forums.scummvm.org/viewtopic.php?p=83240 [08:17] He seems to have an issue with the new tracker. [08:19] I replied to him yesterday already [08:20] Oh, OK. It looks like he didn't see your answer. Maybe all scummvm.org emails are going to his spam box :P [08:20] broken e-mail? right.. [08:22] if you feel like directly replying on the forum, I reset his email verification state yesterday, so he can try setting his email address in trac again [08:23] OK yes, I will reply on the forum. [08:23] oh wait, he does seem to have replied to me [08:24] FreeTHX (~freethx@5.51.235.218) left irc: Ping timeout: 249 seconds [08:24] and also didn't receive the second confirmation email [08:25] hrm [08:25] oh, so another problem then. I will let you deal with it. [08:25] Also I need to leave for work. bbl [08:25] criezy (~criezy@host86-175-211-233.range86-175.btcentralplus.com) left irc: Quit: criezy [08:27] "Please contact your Internet service provider since part of their network is on our block list." [08:27] I hate email [09:00] Lightkey (~jonas@p200300764C08987022CF30FFFE083718.dip0.t-ipconnect.de) left irc: Ping timeout: 250 seconds [09:08] wjp: did you read the log? [09:09] yes [09:09] so script bug [09:10] yes [09:10] it seems that day 5 stuff was coded separately and is incorrect in that regard [09:10] i guess we will have to research what it does on other days [09:11] maybe that old dialog is meant to be played as well but only in certain conditions [09:11] and the second call to the drum book code is definitely incorrect [09:11] will be a mess to fix [09:11] maybe there is even special dialog that was supposed to play [09:12] analyzing all possible ways / item combination / flag combinations with which you can get there sounds hard... [09:13] well, it seems getTheVeve is the problem. [09:13] but yeah [09:13] Lightkey (~jonas@p200300764C08988022CF30FFFE083718.dip0.t-ipconnect.de) joined #scummvm. [09:13] it's really weird. For the first drum call it seems they check 2 inventory items [09:14] and for the second call they check an export from script 0, possibly some flag [09:14] ah wait, script 13, not 0 [09:15] and it seems that duplicate stuff from day 4 is caused by code that also checks stuff via that script 13 call [09:15] those script 13 calls are setting/check (bit) flags IIRC [09:16] yes, flags [09:16] still it's weird that it isn't in script 0. Possibly because of size limitations [09:16] typically sierra games had those exports in script 0 [09:17] i guess it will require quite a bit of testing. [09:17] maybe they don't even save that they already triggered that dialog on day 4 [09:17] that would be quite awful [09:19] _sev|work (~sev@scummvm/undead/sev) joined #scummvm. [09:19] #scummvm: mode change '+o _sev|work' by ChanServ!ChanServ@services. [09:22] ST (~ScottT@203-227-181-180.cpe.skymesh.net.au) left irc: Quit: Leaving. [09:23] ST (~ScottT@203-227-181-180.cpe.skymesh.net.au) joined #scummvm. [09:23] #scummvm: mode change '+o ST' by ChanServ!ChanServ@services. [09:32] GitHub51 (~GitHub51@192.30.252.40) joined #scummvm. [09:32] [scummvm] sev- pushed 1 new commit to master: https://git.io/viWhd [09:32] scummvm/master 573df10 Eugene Sandulenko: FULLPIPE: Fixed bat fall logic in scene27 [09:32] GitHub51 (GitHub51@192.30.252.40) left #scummvm. [10:36] Strangerke|work (5bb7582b@gateway/web/freenode/ip.91.183.88.43) left irc: Quit: Page closed [11:11] waltervn (~waltervn@82-171-142-149.ip.telfort.nl) left irc: Ping timeout: 244 seconds [11:23] Henke37 (~Henrik@81-227-16-59-no133.bredband.skanova.com) joined #scummvm. [11:29] sluicebox (~cbone@cpe-76-169-81-22.socal.res.rr.com) joined #scummvm. [11:35] So about that gk day 5 stuff... I got deep into it and figured out all the flags and legal combos [11:36] <_sev|work> sounds exciting [11:36] I'll pick it up tomorrow to do some testing, at which point i should be able to talk coherently about what that script mess is up to [11:36] <_sev|work> maybe it makes sense to share this knowledge on our Wiki? [11:37] so, if anyone was about to put themselves through that pain, we may be able to spare that [11:38] it IS exciting! i mean, not in a way i'd admit to someone on the street... [11:38] m_kiewitz: ^ [11:38] ahh [11:39] need to go to work, but sluicebox im very interested :P will be home in 4 hours or so [11:39] that will help us patching that script [11:39] sluicebox: can you read SCI scripts? [11:40] it's getTheVeve::changeState in script 212 that is doing those things. state 0 triggers the "get the drum book" script and it's later triggered again [11:40] not assembly but what scicompanion can figure out [11:41] ah, yeah please look at that, with your knowledge, maybe you can even figure out exactly what they are checking [11:41] state 0Bh (11d) is triggering the "get the drum book" once more [11:41] yeah i figured out all the flags and inventory ids they're testing in all that [11:41] but both check different things. the first state checks inventory of the player, the 0Bh one checks a flag [11:41] it's really weird [11:41] anyway got to go [11:42] it is; i'm through the looking glass on it [11:59] looking forward to hearing what you figure out [13:11] Littleboy (~littleboy@c-71-233-131-7.hsd1.ma.comcast.net) joined #scummvm. [13:11] #scummvm: mode change '+o Littleboy' by ChanServ!ChanServ@services. [13:33] snover (~Adium@unaffiliated/snover) joined #scummvm. [13:33] #scummvm: mode change '+o snover' by ChanServ!ChanServ@services. [14:13] _sev|work_ (~sev@scummvm/undead/sev) joined #scummvm. [14:13] _sev|work (~sev@scummvm/undead/sev) left irc: Read error: Connection reset by peer [14:13] #scummvm: mode change '+o _sev|work_' by ChanServ!ChanServ@services. [14:27] deitarion (~ssokolow@moinmoin/fan/deitarion) joined #scummvm. [14:29] I have my eyes on a pair of Discworld 2 CDs but they don't come with a manual. Does the ScummVM wiki have any kind of reference chart detailing which games require the manual to be completable? [14:42] Strangerke (~Strangerk@cable-85.28.84.13.coditel.net) joined #scummvm. [14:42] #scummvm: mode change '+o Strangerke' by ChanServ!ChanServ@services. [14:47] Strangerke_ (~Strangerk@cable-85.28.84.13.coditel.net) joined #scummvm. [14:47] #scummvm: mode change '+o Strangerke_' by ChanServ!ChanServ@services. [14:50] Strangerke (~Strangerk@cable-85.28.84.13.coditel.net) left irc: Ping timeout: 276 seconds [14:51] <_sev|work_> deitarion: no, we never tracked that [14:51] Nick change: _sev|work_ -> _sev|work [14:53] Drat. Time for more googling, then. [15:04] ST (~ScottT@203-227-181-180.cpe.skymesh.net.au) left irc: Ping timeout: 240 seconds [15:15] ST (~ScottT@203-227-181-180.cpe.skymesh.net.au) joined #scummvm. [15:15] #scummvm: mode change '+o ST' by ChanServ!ChanServ@services. [15:27] GitHub3 (~GitHub3@192.30.252.45) joined #scummvm. [15:27] [scummvm] eriktorbjorn pushed 2 new commits to master: https://git.io/vilyD [15:27] scummvm/master 12973f4 Torbjörn Andersson: FULLPIPE: Free _backgroundSurface when the game ends [15:27] scummvm/master 7db3902 Torbjörn Andersson: FULLPIPE: Free _soundItems when SoundList is deleted [15:27] GitHub3 (GitHub3@192.30.252.45) left #scummvm. [15:45] GitHub121 (~GitHub121@192.30.252.40) joined #scummvm. [15:45] [scummvm] eriktorbjorn pushed 1 new commit to master: https://git.io/vilQf [15:45] scummvm/master bffc1f8 Torbjörn Andersson: FULLPIPE: Also free the contents of _soundList, along with it [15:45] GitHub121 (GitHub121@192.30.252.40) left #scummvm. [15:46] _sev|work (~sev@scummvm/undead/sev) left irc: Quit: This computer has gone to sleep [15:49] deitarion (ssokolow@moinmoin/fan/deitarion) left #scummvm ("ISON jab416171 TheCycoONE ultra "). [15:50] GitHub137 (~GitHub137@192.30.252.45) joined #scummvm. [15:50] [scummvm] eriktorbjorn pushed 1 new commit to master: https://git.io/vilQ5 [15:50] scummvm/master 01d99a5 Torbjörn Andersson: FULLPIPE: Free contents of Bitmap surface when deleting bitmap... [15:50] GitHub137 (GitHub137@192.30.252.45) left #scummvm. [16:05] ajax16384 (~User@ip138.net138.n37.ru) left irc: Quit: Leaving [16:36] ny00123 (~ny00123@217.132.60.19) joined #scummvm. [16:39] snover (~Adium@unaffiliated/snover) left irc: Quit: Leaving. [16:45] _sev|work (~sev@scummvm/undead/sev) joined #scummvm. [16:45] #scummvm: mode change '+o _sev|work' by ChanServ!ChanServ@services. [16:45] _sev|work (~sev@scummvm/undead/sev) left irc: Remote host closed the connection [16:45] GitHub49 (~GitHub49@192.30.252.41) joined #scummvm. [16:45] [scummvm] sev- pushed 1 new commit to master: https://git.io/viljJ [16:45] scummvm/master 5c07eee Eugene Sandulenko: FULLPIPE: Further corrections to scene27 [16:45] GitHub49 (GitHub49@192.30.252.41) left #scummvm. [16:48] Mia (~Mia@unaffiliated/mia) joined #scummvm. [16:55] |Cable| (~cable@33.138.117.91.dynamic.reverse-mundo-r.com) left irc: Ping timeout: 244 seconds [17:07] |Cable| (~cable@33.138.117.91.dynamic.reverse-mundo-r.com) joined #scummvm. [17:12] waltervn (~waltervn@82-171-142-149.ip.telfort.nl) joined #scummvm. [17:12] #scummvm: mode change '+o waltervn' by ChanServ!ChanServ@services. [17:22] Cruel` (~cruel@65-33-179-238.res.bhn.net) joined #scummvm. [17:35] ajax16384 (~User@ip33.net130.n37.ru) joined #scummvm. [17:35] #scummvm: mode change '+o ajax16384' by ChanServ!ChanServ@services. [17:53] frankyboy_ (~franky@ppp46-138-179-107.pppoe.spdop.ru) joined #scummvm. [17:57] FreeTHX (~freethx@5.51.235.218) joined #scummvm. [18:21] criezy (~criezy@host86-175-211-233.range86-175.btcentralplus.com) joined #scummvm. [18:21] #scummvm: mode change '+o criezy' by ChanServ!ChanServ@services. [18:24] girafe (~girafe@LFbn-1-8015-136.w90-112.abo.wanadoo.fr) joined #scummvm. [18:29] Star Trek 25h Anniversary / Cinemassacre https://www.youtube.com/watch?v=HV9jWxvDCAM [18:37] hello [18:38] i would like to talk about, then aggressively forget, day 5 =) [18:39] :-) [18:39] hi [18:41] hi! so... the bug revolves around two research requests you make to grace [18:41] each of these results in her giving you a new item at the start of the next day [18:42] you can request veve pattern research and get a newspaper clipping the next day [18:42] you can request rada drum research and get a drum book the next day [18:42] the veve research can only be requsted on days 3 and 4 [18:42] the drum research can only be requetsed on days 4 and 5 [18:43] so the start of day 5 needs to handle four combinations of incoming items from grace [18:43] and the intro script handles three of them, and messes up the dialouge on the fourth. given that script... not bad [18:44] it messes up when you already have the newspaper clipping (you requested research on day 3) and the drum book comes in on day 5 (you requested that research on day 4) [18:45] the day 5 intro script is pretty bad, but it's only testing four inputs [18:45] two flags, two inventory items [18:45] flag 36 is AskedForVeveResearch and 73 is AskedForDrumResearch [18:45] they get set as soon as you ask grace to do that research, they stay set forever [18:46] item 9 is the newspaper clipping, 14 is the rada drum book [18:47] ah, so it checks for that flag and then should also check if you already have the item and then skip the sequence [18:47] using that, the script *should* be as simple as two "Do I owe you an item? Here's the item. Next." but instead... it's insane [18:47] lol, yeah i saw that [18:48] Right. That first check in startOfDay5 that determines if getTheVeve is called looks weird but is really just "Are you owed anything today?" [18:48] thanks for the very clear description of what's going on! [18:48] you're welcome! [18:48] but man, everything in that script is in the wrong place [18:48] several parts are unreachable [18:49] so what exactly is missing then? i guess they don't check for at least the veve item [18:49] it's hard to describe just how wrong this is? [18:49] but i have a patch suggestion! [18:50] hopefully it's sci bytecode friendly [18:50] well i will need to figure out a way to save some bytes and then add extra bytes [18:50] i guess one of those "drum book" calls could be removed, so that would save quite a few bytes [18:51] right; i'm optimistic [18:51] any idea in what order those make sense? first one is wrong or last one? [18:51] yes! [18:51] which? :P [18:51] if the first one (state 0) can be NOP'd out while keeping the surrounding if / else that would be step 1 [18:52] so that only the one in state 11 remains [18:52] and the second patch would be to the code in state 1 [18:53] decompiled, there's a part that looks like this: [18:53] (if (and (not (gGKEgo has: 14)) (gGKEgo has: 9)) [18:53] (self changeState: 12) ; this code is unreachable [18:53] (gGKEgo get: 14) [18:53] if that were patched to: [18:53] (if (gGKEgo has: 9)) [18:53] (self changeState: 11) [18:54] NOP the last line [18:54] everything should be okay [18:54] wait, right at the start of getTheVeve there are two "has" calls [18:55] girafe2 (~girafe@LFbn-1-8015-136.w90-112.abo.wanadoo.fr) joined #scummvm. [18:55] yes, those are wrong but their wrongness will cancel out another wrong. they should be left as is [18:55] and when both are false it jumps to the drum book stuff [18:56] so that if that condition is met, nothing happens, and otherwise it will play gabriel's line: (gGkMessager say: 11 0 45 1 self) [18:56] so only that would need to be removed and just skip the state instead and continue with step 1? [18:56] girafe (~girafe@LFbn-1-8015-136.w90-112.abo.wanadoo.fr) left irc: Ping timeout: 255 seconds [18:56] that would be easier than expected [18:56] everything else looks correct? [18:56] so in your saved game, you would remove the first drum book sequence, everything else would stay the same [18:56] i'm walking through what you said, i know the patch doesn't look like it makes sense but there's a couple wrong things it's undoing [18:57] but wait, you said that you get dialog from day 4? [18:57] so that means that some check is missing [18:57] In my save game it would TWO changes [18:57] frankyboy_ (~franky@ppp46-138-179-107.pppoe.spdop.ru) left irc: Remote host closed the connection [18:57] because it does two things wrong [18:57] it would remove the first drunk book sequence [18:58] it would then remove the incomplete sequence about the newspaper clipping, an item i already have (cuz that sequence happened yesterday) [18:58] state 1 trigger the "yes, i did find something dialog" [18:58] can this line happen at all in case ego has 14 + 9 in inventory? [18:59] ah, wait, yes thats the newspaper clipping [18:59] there's a check around the one call to getTheVeve that ensures that you are owed at least one thing that day [18:59] but is that part of the code totally incorrect then? or is something even missing ("yes, i did find" - i guess some dialog should lay before) [19:00] no here's how they screwed that part up... [19:00] the first line is gabriel's [19:00] so there are three things wrong with my save game [19:00] lol :P [19:00] double rada drum [19:00] yesterday's newspaper line [19:00] er, dialouge [19:01] and the newspaper dialouge is messed up, it skips gabriel's first line, cuz they wrapped that in the else block of state 0 [19:01] ah i see [19:01] so i need to jump over some states in case "get the drum book" is triggered [19:01] right [19:02] so the correct state to jump to is 11? [19:02] and what they've got there in state 0, though it looks wrong, ends up working as long as you just don't call getTheDrumBook [19:02] and in state 1, right, jump to 11 [19:02] BUT remove that crazy line that gives away the drum book (that happens correctly a few lines up) [19:03] well i would jump from inside state 0, because removing the drum book call makes some bytes available [19:03] SylvainTV (~SylvainTV@LFbn-1-8392-241.w81-254.abo.wanadoo.fr) joined #scummvm. [19:03] #scummvm: mode change '+o SylvainTV' by ChanServ!ChanServ@services. [19:03] and the 3rd problem? [19:03] btw. do you own Gabriel Knight 1 floppy? [19:03] if you jump from 0 to 11 there will a problem [19:04] someone should check the scripts if they are a) the same code (I guess so) and b) if my patch will fix that too [19:04] because grace's line is in state 1 [19:04] frankyboy_ (~franky@ppp46-138-179-107.pppoe.spdop.ru) joined #scummvm. [19:04] ah [19:04] i am shaking my head at it all over again... lol [19:04] but i got this "yes, I found something". That's supposed to play in any case? [19:05] or well, shouldn't there a gabriel line in front of that one? [19:05] yes, that happens when read SCI scripts :P [19:05] you [19:05] read SCI scripts [19:06] I need to trace through that slowly before I confuse things =) [19:06] you could also set breakpoints yourself in ScummVM [19:06] just enter for example [19:06] bpx getTheVeve::changeState [19:06] after pressing Ctrl-Shift-D to enter debugger [19:06] if you're getting the newspaper, it should go gabriel in state 0 "Did you find anythin?", grace in state 1 "Yeah...", and continue on 2, 3, .... [19:07] is there a way i can call the functions that set / read the flags from the scummvm debugger? [19:08] you can't call exports yourself, at least as far as i know [19:08] you could of course modify a global yourself [19:08] right, i figured that would be too good to be true =) [19:09] you can also set selectors to a specific value and i think even call selectors too [19:09] i will just try to add a patch for fixing state 0 [19:09] it seems that should work fine then with your saved game [19:10] so that conditional in state 0, "if not has 14 and has 9", it's impossible to start day 5 with the drum book (14), so it is effectively just "if has 9" [19:10] ah another way to save even more bytes [19:11] and since day 5 is the last possible day to get the newspaper clip, and you're only in this script if you're owed an item, if you don't have the newspaper clip you're getting the newspaper clip [19:12] so state 1 untangles to "if not has newspaper clip" then kick off "Did you find a anything?" [19:13] *state 0 [19:16] hm, is this function only called in day 5? [19:16] yes [19:17] (not at home currently, so I can't read along) [19:17] the names are real bad [19:17] getTheDrumBook does everything except put a drum book in your inventory [19:17] so is this all essentially duplicated for the other days? [19:17] yes; this looks like a copy paste tweak disaster [19:17] oh dear [19:19] each of these sequences is about syncing three things: the text, inventory, and points, and they just cast each of those things to the wind [19:26] another gotcha, so in state 0 you can simplify "if not has 14 and has 9" to just "if has 9" because it's impossible to have 14 there (rada books) [19:27] but then in state 1 they repeat that same conditional, but this time they slipped right in front of it a line that sometimes gives you 14, so now you HAVE to patch that test to just "if has 9" [19:47] sluicebox: can you compile ScummVM yourself? [19:47] yes [19:52] GitHub196 (~GitHub196@192.30.252.34) joined #scummvm. [19:52] [scummvm] m-kiewitz pushed 1 new commit to master: https://git.io/vi8go [19:52] scummvm/master 858bfdf Martin Kiewitz: SCI32: Add script patch for fixing game dialogue error on day 5... [19:52] GitHub196 (GitHub196@192.30.252.34) left #scummvm. [19:52] sluicebox: ^^ here you go [19:54] anyowns owns the GK1 floppy version? [19:54] anyone [20:09] testing the script patches now... [20:24] t0by (~t0by@host2-202-dynamic.44-79-r.retail.telecomitalia.it) joined #scummvm. [20:24] #scummvm: mode change '+v t0by' by ChanServ!ChanServ@services. [20:32] The script patch works great! [20:32] I ran all four combos through it, thanks! [20:33] I'm forgetting all of it now... it's... bliss... [20:43] ny00123 (~ny00123@217.132.60.19) left irc: Quit: Leaving [20:57] oops! i spoke too soon [20:58] so the patch creates the right dialouge flow for the broken scenario, but the drum book doesn't end up in inventory. [21:01] it's jumping from state 0 to state 10 to call getTheDrumCode in state 11, [21:02] *getTheDrumBook [21:02] but getTheDrumBook does everything BUT put the drum book in the inventory [21:03] the drum book is put in inventory by state 1 of getTheVeve [21:06] snover (~Adium@unaffiliated/snover) joined #scummvm. [21:06] #scummvm: mode change '+o snover' by ChanServ!ChanServ@services. [21:06] so that's why i was thinking getTheVeve state 0 needs to just not call getTheDrumCode but proceed to state 1, where it sets inventory if appropriate, and then the rest of state 1 should be patched to skip past the newspaper code. [21:15] oh [21:15] need to check the code once more, dang :P [21:16] criezy (~criezy@host86-175-211-233.range86-175.btcentralplus.com) left irc: Quit: criezy [21:22] frankyboy_ (~franky@ppp46-138-179-107.pppoe.spdop.ru) left irc: Remote host closed the connection [21:46] sluicebox (~cbone@cpe-76-169-81-22.socal.res.rr.com) left irc: Ping timeout: 264 seconds [21:51] t0by (~t0by@host2-202-dynamic.44-79-r.retail.telecomitalia.it) left irc: Quit: Bye! [21:53] WooShell (~Markus@ipbcc071f7.dynamic.kabel-deutschland.de) left irc: Quit: Zu gotdy od mpy nrmy stpimf. Zu drvpmf zrsmd aogy jrt iq pt viy jrt yp yjr htpimf. [21:56] ajax16384 (~User@ip33.net130.n37.ru) left irc: Read error: Connection reset by peer [22:37] dreammaster (~dreammast@c-73-167-118-204.hsd1.ma.comcast.net) joined #scummvm. [22:37] #scummvm: mode change '+o dreammaster' by ChanServ!ChanServ@services. [22:40] Cool, just a seennick works as a summoning now :) [22:40] Wazzzup [22:41] I wanted your opinion about a nasty if statement :D [22:41] Ah.. one of those things. :P [22:42] sluicebox (~cbone@107-143-150-225.lightspeed.irvnca.sbcglobal.net) joined #scummvm. [22:46] GitHub65 (~GitHub65@192.30.252.42) joined #scummvm. [22:46] [scummvm] m-kiewitz pushed 1 new commit to master: https://git.io/vi8NY [22:46] scummvm/master 71d20da Martin Kiewitz: SCI32: Fix GK1 day 5 script patch... [22:46] GitHub65 (GitHub65@192.30.252.42) left #scummvm. [22:46] sluicebox: can you please try it again? [22:47] i guess we could now have an original issue again in case you can get drum book and veve newspaper at the same time (first sentence will get cut off) [22:47] but ego should get the drum book now [22:52] girafe2 (~girafe@LFbn-1-8015-136.w90-112.abo.wanadoo.fr) left irc: Read error: Connection reset by peer [22:54] movAX13h (~ice@178-191-27-129.adsl.highway.telekom.at) joined #scummvm. [22:56] Hello! Is there a way to configure the size of the launcher? (testing on pocket chip, 480x272) [22:58] it works very good but not everything is visible [23:04] I will try it [23:09] SylvainTV (~SylvainTV@LFbn-1-8392-241.w81-254.abo.wanadoo.fr) left irc: Read error: Connection reset by peer [23:38] I just tried all four dialogs and all dialouge was correct, inventory got set correctly. Nothing got cut off! [23:39] ha, finally [23:40] sounds like you guys are having fun [23:40] ill try to keep you seeded with bugs to fix :) [00:00] --- Fri Sep 9 2016