[00:04] way smarter than companies trying to charge for peer-to-peer multiplayer [00:04] (which means trying to charge for literally nothing) [00:30] omer_mor (~Omer@46-117-132-33.bb.netvision.net.il) joined #scummvm. [00:32] omer_mor_ (~Omer@46-117-132-33.bb.netvision.net.il) left irc: Ping timeout: 264 seconds [01:09] WinterGrascph (~WinterGra@catv-178-48-146-216.catv.broadband.hu) left irc: Ping timeout: 245 seconds [01:10] dreammaster (~dreammast@c-73-167-118-204.hsd1.ma.comcast.net) joined #scummvm. [01:10] #scummvm: mode change '+o dreammaster' by ChanServ!ChanServ@services. [01:12] m_kiewitz (~m_kiewitz@scummvm/undead/m-kiewitz) left irc: Quit: technology isn't intrinsically good or evil. It's how it's used. Like the Death Ray. [01:15] WinterGrascph (~WinterGra@catv-178-48-146-216.catv.broadband.hu) joined #scummvm. [01:15] #scummvm: mode change '+o WinterGrascph' by ChanServ!ChanServ@services. [01:19] Axy (~Mia@85.110.65.166) joined #scummvm. [01:19] Axy (~Mia@85.110.65.166) left irc: Changing host [01:19] Axy (~Mia@unaffiliated/mia) joined #scummvm. [01:22] Mia (~Mia@unaffiliated/mia) left irc: Ping timeout: 240 seconds [01:25] GitHub55 (~GitHub55@192.30.252.34) joined #scummvm. [01:25] [scummvm] dreammaster pushed 1 new commit to master: https://git.io/vDOnX [01:25] scummvm/master 0d6578d Paul Gilbert: TITANIC: Git rid of old stubs in CMusicRoomHandler, start fleshing it out [01:25] GitHub55 (GitHub55@192.30.252.34) left #scummvm. [02:17] Dominus (~dominus@unaffiliated/dominus) left irc: Ping timeout: 240 seconds [02:18] Dominus (~dominus@178-190-61-110.adsl.highway.telekom.at) joined #scummvm. [02:18] Dominus (~dominus@178-190-61-110.adsl.highway.telekom.at) left irc: Changing host [02:18] Dominus (~dominus@unaffiliated/dominus) joined #scummvm. [02:39] WinterGrascph (~WinterGra@catv-178-48-146-216.catv.broadband.hu) left irc: Ping timeout: 264 seconds [02:43] Vampire0_ (~Vampire@jEdit/Vampire) joined #scummvm. [02:43] GitHub174 (~GitHub174@192.30.252.34) joined #scummvm. [02:43] [scummvm] dreammaster pushed 1 new commit to master: https://git.io/vDO83 [02:43] scummvm/master 29f9132 Paul Gilbert: TITANIC: Implemented CAudioBuffer class [02:43] GitHub174 (GitHub174@192.30.252.34) left #scummvm. [02:46] Vampire0 (~Vampire@jEdit/Vampire) left irc: Ping timeout: 240 seconds [03:37] dreammaster (~dreammast@c-73-167-118-204.hsd1.ma.comcast.net) left irc: [03:41] Cheeseness (~cheesenes@ppp14-2-162-157.bras1.hba2.internode.on.net) left irc: Ping timeout: 240 seconds [03:50] Littleboy (~littleboy@c-73-186-252-231.hsd1.ma.comcast.net) left irc: Quit: Ętre dans le vent, une ambition de feuille morte. [04:08] ComradeAnderson (~ComradeAn@unaffiliated/comradeanderson) joined #scummvm. [04:09] Cheeseness (~cheesenes@ppp14-2-162-157.bras1.hba2.internode.on.net) joined #scummvm. [04:10] te_lanus (~te_lanus@154.66.195.97) joined #scummvm. [04:33] BeefEats (~BeefEats@unaffiliated/beefeats) joined #scummvm. [04:34] BeefEats (~BeefEats@unaffiliated/beefeats) left irc: Client Quit [05:02] i think ill need a co-conspirator to help me if the brittle script load order dependency is going to be overcome. for now i feel satisfied that ive patched the SRDialog in a manner that does not change the load order, so all the save games interoperate successfully regardless of the original save/load setting. [05:05] i still need to work on the restore-from-loader functionality, that breaks the crap out of things [06:10] exmensa (~exmensa@66.43.202.238) joined #scummvm. [06:12] Tomaz^W2 (~tompsson@84.216.7.40) joined #scummvm. [06:12] Tomaz^W (~tompsson@84.216.7.40) left irc: Ping timeout: 264 seconds [06:12] qvist (~qvist@delta.ipv7.se) left irc: Ping timeout: 264 seconds [06:12] qvist (~qvist@delta.ipv7.se) joined #scummvm. [06:12] #scummvm: mode change '+v qvist' by ChanServ!ChanServ@services. [06:12] LittleToonCat (~littlecat@sydnns0115w-047054148237.dhcp-dynamic.FibreOP.ns.bellaliant.net) left irc: Ping timeout: 264 seconds [06:12] exmensa_ (exmensa@66.43.202.238) left irc: Ping timeout: 264 seconds [06:13] LittleToonCat (~littlecat@sydnns0115w-047054148237.dhcp-dynamic.FibreOP.ns.bellaliant.net) joined #scummvm. [07:38] Mia (~Mia@unaffiliated/mia) joined #scummvm. [07:40] Axy (~Mia@unaffiliated/mia) left irc: Ping timeout: 248 seconds [07:45] m_kiewitz (~m_kiewitz@scummvm/undead/m-kiewitz) joined #scummvm. [07:45] #scummvm: mode change '+o m_kiewitz' by ChanServ!ChanServ@services. [08:05] Nick change: Vampire0_ -> Vampire0 [08:11] Lightkey (~Darklock@p200300764C2EBF4422CF30FFFE083718.dip0.t-ipconnect.de) left irc: Ping timeout: 258 seconds [08:14] travis-ci (~travis-ci@ec2-54-91-250-154.compute-1.amazonaws.com) joined #scummvm. [08:14] scummvm/scummvm#2534 (master - 0d6578d : Paul Gilbert): The build passed. [08:14] Change view : https://github.com/scummvm/scummvm/compare/d39404c8e814...0d6578dac704 [08:14] Build details : https://travis-ci.org/scummvm/scummvm/builds/197506155 [08:14] travis-ci (travis-ci@ec2-54-91-250-154.compute-1.amazonaws.com) left #scummvm. [08:18] GitHub175 (~GitHub175@192.30.252.42) joined #scummvm. [08:18] [scummvm] sev- pushed 1 new commit to master: https://git.io/vDOig [08:18] scummvm/master 255c76b Eugene Sandulenko: GRAPHICS: Optimize for empty substrings in MacText [08:18] GitHub175 (GitHub175@192.30.252.42) left #scummvm. [08:20] waltervn (~waltervn@541B2DBA.cm-5-4a.dynamic.ziggo.nl) joined #scummvm. [08:20] #scummvm: mode change '+o waltervn' by ChanServ!ChanServ@services. [08:21] Strangerke|work (5bb7582b@gateway/web/freenode/ip.91.183.88.43) joined #scummvm. [08:21] hi guys [08:24] Lightkey (~Darklock@p200300764C2EBF3022CF30FFFE083718.dip0.t-ipconnect.de) joined #scummvm. [08:24] morning [08:39] _sev|work (~sev@scummvm/undead/sev) joined #scummvm. [08:39] #scummvm: mode change '+o _sev|work' by ChanServ!ChanServ@services. [08:52] GitHub126 (~GitHub126@192.30.252.45) joined #scummvm. [08:52] [scummvm] waltervn pushed 1 new commit to master: https://git.io/vDO1v [08:52] scummvm/master 1ae539d Walter van Niftrik: ADL: Increase robustness of graphics code [08:52] GitHub126 (GitHub126@192.30.252.45) left #scummvm. [09:09] _sev|work (~sev@scummvm/undead/sev) left irc: Quit: This computer has gone to sleep [09:09] GitHub11 (~GitHub11@192.30.252.45) joined #scummvm. [09:09] [scummvm] sev- pushed 1 new commit to master: https://git.io/vDOM1 [09:09] scummvm/master c30df01 Eugene Sandulenko: GRAPHICS: More optimization for empty strings [09:09] GitHub11 (GitHub11@192.30.252.45) left #scummvm. [09:13] travis-ci (~travis-ci@ec2-54-160-128-1.compute-1.amazonaws.com) joined #scummvm. [09:13] scummvm/scummvm#2535 (master - 29f9132 : Paul Gilbert): The build passed. [09:13] Change view : https://github.com/scummvm/scummvm/compare/0d6578dac704...29f913289cd0 [09:13] Build details : https://travis-ci.org/scummvm/scummvm/builds/197517968 [09:13] travis-ci (travis-ci@ec2-54-160-128-1.compute-1.amazonaws.com) left #scummvm. [09:25] ajax16384 (~User@109.60.138.138) joined #scummvm. [09:25] #scummvm: mode change '+o ajax16384' by ChanServ!ChanServ@services. [09:30] LittleToonCat (~littlecat@sydnns0115w-047054148237.dhcp-dynamic.FibreOP.ns.bellaliant.net) left irc: Remote host closed the connection [09:42] _sev|work (~sev@5.57.20.49) joined #scummvm. [09:42] _sev|work (~sev@5.57.20.49) left irc: Changing host [09:42] _sev|work (~sev@scummvm/undead/sev) joined #scummvm. [09:42] #scummvm: mode change '+o _sev|work' by ChanServ!ChanServ@services. [09:42] peterkohaut|work (~peterkoha@188-167-125-162.dynamic.chello.sk) left irc: Read error: Connection reset by peer [09:43] peterkohaut|work (~peterkoha@188-167-125-162.dynamic.chello.sk) joined #scummvm. [10:12] TMM (~hp@fsf/member/pdpc.professional.tmm) joined #scummvm. [10:12] #scummvm: mode change '+o TMM' by ChanServ!ChanServ@services. [10:14] Axy (~Mia@unaffiliated/mia) joined #scummvm. [10:17] Mia (~Mia@unaffiliated/mia) left irc: Ping timeout: 240 seconds [11:00] GitHub45 (~GitHub45@192.30.252.34) joined #scummvm. [11:00] [scummvm] waltervn pushed 1 new commit to master: https://git.io/vDOAn [11:00] scummvm/master 2841dd2 Walter van Niftrik: ADL: Set ADGF_TESTING for hires5 [11:00] GitHub45 (GitHub45@192.30.252.34) left #scummvm. [11:23] Deledrius (~Deledrius@2602:100:4476:8bd6:659a:84e5:bdcf:324e) left irc: Quit: App.Exit [11:27] Deledrius (~Deledrius@2602:100:4476:8bd6:1921:3d9a:26e:3af1) joined #scummvm. [11:42] dtcrshr (~datacrush@unaffiliated/datacrusher) joined #scummvm. [11:52] dtcrshr (~datacrush@unaffiliated/datacrusher) left irc: Read error: Connection reset by peer [11:53] te_lanus (~te_lanus@154.66.195.97) left irc: Remote host closed the connection [12:01] user9 (~Thunderbi@leoseb.ujf-grenoble.fr) left irc: Remote host closed the connection [12:02] user9 (~Thunderbi@leoseb.ujf-grenoble.fr) joined #scummvm. [12:35] Nick change: peterkohaut|work -> peterkohaut [12:47] Axy (~Mia@unaffiliated/mia) left irc: Ping timeout: 248 seconds [12:53] BeefEats (~BeefEats@unaffiliated/beefeats) joined #scummvm. [12:54] BeefEats (~BeefEats@unaffiliated/beefeats) left irc: Client Quit [13:16] Mia (~Mia@88.227.167.201) joined #scummvm. [13:16] Mia (~Mia@88.227.167.201) left irc: Changing host [13:16] Mia (~Mia@unaffiliated/mia) joined #scummvm. [13:24] Mia (~Mia@unaffiliated/mia) left irc: Ping timeout: 240 seconds [13:39] Mia (~Mia@85.110.5.209) joined #scummvm. [13:39] Mia (~Mia@85.110.5.209) left irc: Changing host [13:39] Mia (~Mia@unaffiliated/mia) joined #scummvm. [14:10] dtcrshr (~datacrush@2801:88:f7a:100:240:a7ff:fe2d:d7c0) joined #scummvm. [14:10] dtcrshr (~datacrush@2801:88:f7a:100:240:a7ff:fe2d:d7c0) left irc: Changing host [14:10] dtcrshr (~datacrush@unaffiliated/datacrusher) joined #scummvm. [14:29] _sev|work (~sev@scummvm/undead/sev) left irc: Quit: This computer has gone to sleep [14:42] Nick change: rootfather|afk -> rootfather [14:46] dtcrshr (~datacrush@unaffiliated/datacrusher) left irc: Ping timeout: 264 seconds [14:54] WinterGrascph (~WinterGra@catv-178-48-146-216.catv.broadband.hu) joined #scummvm. [14:54] #scummvm: mode change '+o WinterGrascph' by ChanServ!ChanServ@services. [14:57] Littleboy (~littleboy@c-73-186-252-231.hsd1.ma.comcast.net) joined #scummvm. [14:57] #scummvm: mode change '+o Littleboy' by ChanServ!ChanServ@services. [15:05] _sev|work (~sev@scummvm/undead/sev) joined #scummvm. [15:05] #scummvm: mode change '+o _sev|work' by ChanServ!ChanServ@services. [15:14] user9 (~Thunderbi@leoseb.ujf-grenoble.fr) left irc: Quit: user9 [15:14] user9 (~Thunderbi@leoseb.ujf-grenoble.fr) joined #scummvm. [15:25] LeChuck joined #scummvm. [15:28] Mia (~Mia@unaffiliated/mia) left irc: Ping timeout: 240 seconds [15:29] Mia (~Mia@85.110.81.251) joined #scummvm. [15:29] Mia (~Mia@85.110.81.251) left irc: Changing host [15:29] Mia (~Mia@unaffiliated/mia) joined #scummvm. [15:29] user9 (~Thunderbi@leoseb.ujf-grenoble.fr) left irc: Quit: user9 [15:30] user9 (~Thunderbi@leoseb.ujf-grenoble.fr) joined #scummvm. [15:31] kurtwr (~kurtwr@c-50-173-166-91.hsd1.ca.comcast.net) left irc: Ping timeout: 240 seconds [16:07] ajax16384 (~User@109.60.138.138) left irc: Quit: Leaving [16:28] ajax16384 (~User@109.60.130.33) joined #scummvm. [16:28] #scummvm: mode change '+o ajax16384' by ChanServ!ChanServ@services. [16:40] Strangerke|work (5bb7582b@gateway/web/freenode/ip.91.183.88.43) left irc: Ping timeout: 260 seconds [16:41] _sev|work (~sev@scummvm/undead/sev) left irc: Quit: This computer has gone to sleep [16:57] Dominus (~dominus@unaffiliated/dominus) left irc: Ping timeout: 240 seconds [17:00] Dominus (~dominus@194-166-157-42.adsl.highway.telekom.at) joined #scummvm. [17:00] Dominus (~dominus@194-166-157-42.adsl.highway.telekom.at) left irc: Changing host [17:00] Dominus (~dominus@unaffiliated/dominus) joined #scummvm. [17:03] WooShell (~Markus@ipbcc071f7.dynamic.kabel-deutschland.de) joined #scummvm. [17:13] meow =^.^= [17:18] kurtwr (~kurtwr@c-50-173-166-91.hsd1.ca.comcast.net) joined #scummvm. [17:25] ny00123 (~ny00123@89-139-172-204.bb.netvision.net.il) joined #scummvm. [17:32] LittleToonCat (~littlecat@sydnns0115w-047054148237.dhcp-dynamic.FibreOP.ns.bellaliant.net) joined #scummvm. [17:38] dtcrshr (~datacrush@2801:88:f7a:100:240:a7ff:fe2d:d7c0) joined #scummvm. [17:38] dtcrshr (~datacrush@2801:88:f7a:100:240:a7ff:fe2d:d7c0) left irc: Changing host [17:38] dtcrshr (~datacrush@unaffiliated/datacrusher) joined #scummvm. [18:21] Freddy Pharkas was released on GOG today [18:21] wow [18:21] TMM (~hp@fsf/member/pdpc.professional.tmm) left irc: Quit: Ex-Chat [18:21] that's amazing [18:24] using dosbox, by the way [18:26] SIERRAW.EXE 1.001.095, SIERRA.EXE 1.001.132 [18:29] oh, and it comes with the floppy version in a subdirectory [18:30] (1.cfs.081) [18:30] ny00123 (~ny00123@89-139-172-204.bb.netvision.net.il) left irc: Remote host closed the connection [18:32] dos interpreter for the cd version has symbols [18:32] (but we knew that already) [18:35] and scummvm detects both versions properly [18:35] ny00123 (~ny00123@89-139-172-204.bb.netvision.net.il) joined #scummvm. [18:38] there is also a design document in the goodies. dunno if it has anything interesting in it [18:41] Farmboy0 (~quassel@p5DD10AC8.dip0.t-ipconnect.de) joined #scummvm. [18:41] Farmboy0 (~quassel@p5DD10AC8.dip0.t-ipconnect.de) left irc: Changing host [18:41] Farmboy0 (~quassel@xoreos/farmboy0) joined #scummvm. [18:54] so there's still hope we might see some of the other lesser known Sierra titles on GOG some day.. [18:58] Guest30711 (~tompsson@h-236-221.a199.priv.bahnhof.se) joined #scummvm. [19:00] Tomaz^ (~tompsson@h-236-221.a199.priv.bahnhof.se) left irc: Ping timeout: 240 seconds [19:02] Gentle (~tier@quassel/contributors/gentle) left irc: Ping timeout: 245 seconds [19:08] frankyboy_ (~franky@ppp109-252-157-233.pppoe.spdop.ru) joined #scummvm. [19:11] _sev|work (~sev@scummvm/undead/sev) joined #scummvm. [19:11] #scummvm: mode change '+o _sev|work' by ChanServ!ChanServ@services. [19:11] L0ngcat: I imagine it's the same as the one on Al Lowe's website [19:12] waltervn: right, did not remember that was already released [19:15] Gentle (~tier@quassel/contributors/gentle) joined #scummvm. [19:15] frankyboy_ (~franky@ppp109-252-157-233.pppoe.spdop.ru) left irc: Read error: Connection reset by peer [19:15] frankyboy_ (~franky@ppp109-252-157-233.pppoe.spdop.ru) joined #scummvm. [19:15] ComradeAnderson (~ComradeAn@unaffiliated/comradeanderson) left irc: Ping timeout: 276 seconds [19:20] frankyboy_ (~franky@ppp109-252-157-233.pppoe.spdop.ru) left irc: Read error: Connection reset by peer [19:20] frankyboy_ (~franky@ppp109-252-157-233.pppoe.spdop.ru) joined #scummvm. [19:22] Dominus (~dominus@unaffiliated/dominus) left irc: Ping timeout: 240 seconds [19:24] Dominus (~dominus@178-191-66-66.adsl.highway.telekom.at) joined #scummvm. [19:24] Dominus (~dominus@178-191-66-66.adsl.highway.telekom.at) left irc: Changing host [19:24] Dominus (~dominus@unaffiliated/dominus) joined #scummvm. [19:25] WinterGrascph (~WinterGra@catv-178-48-146-216.catv.broadband.hu) joined #scummvm. [19:25] #scummvm: mode change '+o WinterGrascph' by ChanServ!ChanServ@services. [19:27] waltervn: yeah, same file [19:36] broosky (~broosky@178235040232.dynamic-ww-05.vectranet.pl) joined #scummvm. [19:37] _sev|work (~sev@scummvm/undead/sev) left irc: Quit: This computer has gone to sleep [19:38] wjp: oh wow, Pharkas? [19:38] it would have been nice in case GOG finally released localized versions on top. It was a nightmare to get at least the German version of Pharkas [19:38] I don't even try to go for the French or Spanish ones [19:38] borosky (~broosky@178235040232.dynamic-ww-05.vectranet.pl) left irc: Ping timeout: 252 seconds [19:47] GitHub105 (~GitHub105@192.30.252.40) joined #scummvm. [19:47] [scummvm] sev- pushed 1 new commit to master: https://git.io/vDsOo [19:47] scummvm/master 3e47d7a Eugene Sandulenko: GRAPHICS: Fix MacText splitter, so less empty font chunks are generated [19:47] GitHub105 (GitHub105@192.30.252.40) left #scummvm. [20:04] criezy (~criezy@host86-175-214-121.range86-175.btcentralplus.com) joined #scummvm. [20:04] #scummvm: mode change '+o criezy' by ChanServ!ChanServ@services. [20:41] ajax16384 (~User@109.60.130.33) left irc: Read error: Connection reset by peer [21:07] hm. seeing some weird-to-me stack frames as i work on adding the integrated save/load to torin. A `call 0x36, 2` is showing up as `export 1` (0x36 is the location of export 2, not export 1, and in any case it is a local call, not a calle), and trying to `&rest`-forward the arguments to the next call, forwards the arguments sent to the last `self` call& [21:07] showing up in backtrace* [21:08] ny00123 (~ny00123@89-139-172-204.bb.netvision.net.il) left irc: Quit: Leaving [21:11] the backtrace for that `call 0x36, 2` is corrected if debugLocalCallOffset is checked first in cmdBacktrace instead of debugExportId [21:12] but that debugExportId should be -1. [21:14] m_kiewitz (~m_kiewitz@scummvm/undead/m-kiewitz) left irc: Read error: Connection reset by peer [21:14] m_kiewitz (~m_kiewitz@x4d03f47f.dyn.telefonica.de) joined #scummvm. [21:14] m_kiewitz (~m_kiewitz@x4d03f47f.dyn.telefonica.de) left irc: Changing host [21:14] m_kiewitz (~m_kiewitz@scummvm/undead/m-kiewitz) joined #scummvm. [21:14] #scummvm: mode change '+o m_kiewitz' by ChanServ!ChanServ@services. [21:20] <_sev> is anyone willing to help me with a technical puzzle in the code? [21:21] _sev: im not sure i can actuallyhelp, but im willing to give it a try if youd like [21:21] <_sev> do you have The Apartment, a D3 demo? [21:21] yes [21:21] <_sev> are you on Mac? [21:21] yes [21:23] <_sev> nice [21:23] oh, looks like i deleted the apartment so would need to get it again [21:23] it was taking up too much disk space i am sure ;) [21:23] <_sev> please you run devtools/create_classicmacfonts.sh [21:24] <_sev> you=NULL [21:24] <_sev> and put the resulting .dat in your extrapath [21:24] ok [21:25] <_sev> it should be 626103 bytes or so [21:25] yep, exactly that many [21:26] <_sev> cool, please run the apartment [21:26] can you send it again? it turns out i deleted it [21:27] <_sev> done [21:28] thanks. https://zetafleet.com/i/5893a5da29ebd.png is the output [21:29] <_sev> perfect [21:29] <_sev> see that dot next to C in the word Click in the right pane? [21:29] <_sev> and that 'to' did not fit [21:29] yes [21:29] <_sev> now [21:30] <_sev> go to graphics/macgui/mactext.cpp [21:30] <_sev> and on line 133 and 184 [21:30] <_sev> turn them into [21:30] <_sev> int w = 0; //getLineWidth(curLine, true); [21:30] <_sev> getLineWidth returns zero anyway for them [21:30] <_sev> recompile and run [21:30] <_sev> the dot should go away [21:31] <_sev> and 'to' will fit [21:31] yes, it is corrected [21:31] <_sev> and I am banging my head against this wall for two days now [21:32] <_sev> interesting fact, is that dot appears when _any_ of these two getWidth occurences are called, and only in those places [21:32] <_sev> and if you call it later, there is no effect [21:34] im investigating! [21:38] ive narrowed it down a bit more, it is this line on mactext.cpp:287 `_textLines[line].width = width;`; changing that to `width + 1` also 'fixes' the problem [21:42] I guess that dot is really the rightmost edge of the 'o' in 'to'? [21:44] that is what i am thinking, some loop back to the left edge [21:48] _sev: the _surface->h < _textMaxWidth check in Mac::reallocSurface seems fishy [21:48] (but presumably unrelated) [21:49] although, it could be related [22:00] TMM (~hp@fsf/member/pdpc.professional.tmm) joined #scummvm. [22:00] #scummvm: mode change '+o TMM' by ChanServ!ChanServ@services. [22:04] does this font have kerning? [22:05] i was just looking at MacFONTFont, none of those fonts have kerning [22:05] but MacFontFamily maybe [22:05] ignalina (~pettersjo@c83-248-43-229.bredband.comhem.se) joined #scummvm. [22:06] (unrelated, macfontfamily has some whitespace errors at the beginning of lines) [22:08] doesnt look like the default glyph width is ever used either [22:09] the alignment is left, so it seems to not be a kTextAlign problem [22:10] if there's no kerning, it doesn't matter, but the wordWrapText initWidth argument won't handle kerning correctly [22:10] macfontfamily also do not seem to have any [22:12] _maxWidth = maxWidth - 1; // This seems to be correct. TODO: More testing is required [22:12] hmm. [22:12] deleting that -1 fixes the rendering [22:13] i gotta go for a while, but my current bet is that is the bad place, mactext.cpp:46 [22:13] <_sev> hmmm [22:14] interesting [22:15] which blit method is inkBasedBlit using for this? [22:15] <_sev> nope, that's not the case [22:15] <_sev> if I move it higher e.g. to director/frame.cpp, line 923 [22:16] <_sev> it brings the problem back [22:16] how do you mean that exactly? [22:16] <_sev> that is, requesting it to draw on surface of that width causes problem [22:17] <_sev> I put there Graphics::MacText mt(ftext, _vm->_wm, font, 0x00, 0xff, width - 1, (Graphics::TextAlign)alignment); [22:17] <_sev> and remove '- 1' from mactext.cpp:46 [22:18] <_sev> that immediately brings that shifting back [22:18] <_sev> but once again, getLineWidth() return 0 [22:18] oddness [22:18] <_sev> so in this case it apparently has some strange side effect affecting the rendering [22:19] wow, ManagedSurface::transBlit is a mess [22:19] but that's just an aside too :-) [22:19] (just checking if any necessary clipping was done) [22:20] (floating point alpha, tons of conditionals in the inner loop, brrr) [22:27] <_sev> yeah, interesting approach with floats. Why not using normal multiplications and shifts? [22:27] <_sev> oh, that's even double [22:28] super-accurate alpha! ;-) [22:29] criezy (~criezy@host86-175-214-121.range86-175.btcentralplus.com) left irc: Quit: criezy [22:29] <_sev> dreammaster: that's how you could do it: https://github.com/scummvm/scummvm/blob/master/graphics/transparent_surface.cpp#L155 [22:33] frankyboy_ (~franky@ppp109-252-157-233.pppoe.spdop.ru) left irc: Remote host closed the connection [22:34] <_sev> wjp: I think I'll look into removing the doubles from there [22:37] _sev: could you try turning _textMaxWidth = MAX(_textMaxWidth, getLineWidth(i)); into _textMaxWidth = MAX(_textMaxWidth, getLineWidth(i, true)); in MacText::recalcDims ? [22:37] (adding a "true" argument to getLineWidth) [22:40] <_sev> oh, right [22:40] if that fixes it, at least part of the problem is that the wordwrapping code caches partial widths in the current line [22:41] <_sev> yes, that's it [22:41] (I mean, it calls getLineWidth on a line before adding more text to it) [22:41] <_sev> thanks! [22:41] <_sev> this is what you call premature optimization [22:42] GitHub144 (~GitHub144@192.30.252.40) joined #scummvm. [22:42] [scummvm] sev- pushed 1 new commit to master: https://git.io/vDs15 [22:42] scummvm/master 165f5f1 Eugene Sandulenko: GRAPHICS: Fix MacText wrapping. Kudos to wjp [22:42] GitHub144 (GitHub144@192.30.252.40) left #scummvm. [22:45] girafe (~girafe@LFbn-1-11729-221.w2-7.abo.wanadoo.fr) joined #scummvm. [22:45] did you see my note about reallocSurface earlier? [22:45] I think the width and height checks for the surface got kind of squashed into one there [22:49] Action: _sev reads up [22:51] <_sev> wjp: yes, that's a copy/paste error [22:54] GitHub22 (~GitHub22@192.30.252.42) joined #scummvm. [22:54] [scummvm] sev- pushed 1 new commit to master: https://git.io/vDsya [22:54] scummvm/master 7b7a0fa Eugene Sandulenko: GRAPHICS: Fix surface reallocation in MacText [22:54] GitHub22 (GitHub22@192.30.252.42) left #scummvm. [22:54] <_sev> wjp: as of kerning, the initWidth is coming when you have first part of the line pre-filled [22:55] <_sev> with current approach that will happen only when there was a font change [22:55] <_sev> which makes kerning not applicable [22:59] marcus_c (~marcus@bahamut-int.mc.pp.se) left irc: Ping timeout: 264 seconds [23:00] ah, I see [23:18] WooShell (~Markus@ipbcc071f7.dynamic.kabel-deutschland.de) left irc: Quit: If you understand or if you don't, if you believe or if you doubt - There's a universal justice, and the eyes of truth are always watching you. [23:25] te_lanus (~te_lanus@154.66.195.97) joined #scummvm. [23:32] ignalina (~pettersjo@c83-248-43-229.bredband.comhem.se) left irc: Quit: ignalina [23:40] Farmboy0 (~quassel@xoreos/farmboy0) left irc: Remote host closed the connection [23:42] m_kiewitz (~m_kiewitz@scummvm/undead/m-kiewitz) left irc: Quit: technology isn't intrinsically good or evil. It's how it's used. Like the Death Ray. [00:00] --- Fri Feb 3 2017